updated base image to ubi9 (#334)

* updated base image to ubi9

Signed-off-by: Henry Li <[email protected]>

* updated golangci-lint config for 1.60.x

Signed-off-by: Henry Li <[email protected]>

---------

Signed-off-by: Henry Li <[email protected]>

Author: bitscuit

Dockerfile

@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.22.5-bullseye as builder
+FROM golang:1.23.0-bullseye as builder
 ARG GOARCH
 
 WORKDIR /workspace
@@ -21,7 +21,7 @@ RUN CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -o namespace-scope-opera
 # Use distroless as minimal base image to package the manager binary
 # Refer to https://github.com/GoogleContainerTools/distroless for more details
 # FROM gcr.io/distroless/static:nonroot
-FROM docker-na-public.artifactory.swg-devops.com/hyc-cloud-private-edge-docker-local/build-images/ubi8-minimal:latest
+FROM docker-na-public.artifactory.swg-devops.com/hyc-cloud-private-edge-docker-local/build-images/ubi9-minimal:latest
 
 ARG VCS_REF
 ARG VCS_URL

common/config/.golangci.yml

@@ -1,6 +1,6 @@
 service:
   # When updating this, also update the version stored in docker/build-tools/Dockerfile in the multicloudlab/tools repo.
-  golangci-lint-version: 1.51.x # use the fixed version to not introduce new linters unexpectedly
+  golangci-lint-version: 1.60.x # use the fixed version to not introduce new linters unexpectedly
 run:
   # timeout for analysis, e.g. 30s, 5m, default is 1m
   deadline: 20m
@@ -10,46 +10,45 @@ run:
   # default value is empty list, but next dirs are always skipped independently
   # from this option's value:
   #   	vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-  skip-dirs:
-    - genfiles$
-    - vendor$
+  # skip-dirs:
+  #   - genfiles$
+  #   - vendor$
 
   # which files to skip: they will be analyzed, but issues from them
   # won't be reported. Default value is empty list, but there is
   # no need to include all autogenerated files, we confidently recognize
   # autogenerated files. If it's not please let us know.
-  skip-files:
-    - ".*\\.pb\\.go"
-    - ".*\\.gen\\.go"
+  # skip-files:
+  #   - ".*\\.pb\\.go"
+  #   - ".*\\.gen\\.go"
 
 linters:
   # please, do not use `enable-all`: it's deprecated and will be removed soon.
   # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
   disable-all: true
   enable:
-    - revive
+    # - deadcode
     - errcheck
-    - gocyclo
+    # - gocyclo
     - gofmt
     - goimports
-    - gosec
+    # - golint
+    - revive
+    # - gosec
     - gosimple
     - govet
+    # - ineffassign
+    # - interfacer
     - lll
-    - misspell
+    # - misspell
     - staticcheck
+    # - structcheck
     - typecheck
     - unconvert
     - unparam
     - unused
-  
+    # - varcheck
   # don't enable:
-  # - deadcode
-  # - golint
-  # - ineffassign
-  # - interfacer
-  # - varcheck
-  # - structcheck
   # - gocritic
   # - bodyclose
   # - depguard
@@ -102,7 +101,7 @@ linters-settings:
   lll:
     # max line length, lines longer will be reported. Default is 120.
     # '\t' is counted as 1 character by default, and can be changed with the tab-width option
-    line-length: 300
+    line-length: 400
     # tab width in spaces. Default to 1.
     tab-width: 1
   unused:
@@ -186,6 +185,15 @@ linters-settings:
       # - unlabelStmt
       # - unnamedResult
       # - wrapperFunc
+  
+  revive:
+    rules:
+      - name: dot-imports
+        arguments:
+          - allowedPackages:
+              - "github.com/onsi/ginkgo"
+              - "github.com/onsi/ginkgo/v2"
+              - "github.com/onsi/gomega"
 
 issues:
   # List of regexps of issue texts to exclude, empty list by default.
@@ -195,6 +203,14 @@ issues:
   exclude:
     - composite literal uses unkeyed fields
 
+  exclude-dirs:
+    - genfiles$
+    - vendor$
+  
+  exclude-files:
+    - ".*\\.pb\\.go"
+    - ".*\\.gen\\.go"
+
   exclude-rules:
     # Exclude some linters from running on test files.
     - path: _test\.go$|^tests/|^samples/

common/scripts/lint_go.sh

@@ -15,4 +15,4 @@
 # limitations under the License.
 #
 
-GOGC=25 golangci-lint run -c ./common/config/.golangci.yml
+GOGC=25 golangci-lint run -c ./common/config/.golangci.yml --timeout=180s

go.mod

@@ -1,6 +1,6 @@
 module github.com/IBM/ibm-namespace-scope-operator/v4
 
-go 1.21
+go 1.23
 
 require (
 	github.com/IBM/controller-filtered-cache v0.3.4
@@ -76,4 +76,3 @@ require (
 
 // fix vulnerability: CVE-2021-3121 in github.com/gogo/protobuf < v1.3.2
 replace github.com/gogo/protobuf => github.com/gogo/protobuf v1.3.2
-