Revert "feat: Add support for evaluating Iceberg partition transforms (facebookincubator#15477)"

This reverts commit 1895711.

Alchemy-item: (ID = 885) Iceberg staging hub commit 2/15 - 388c27d

Author: PingLiuPing

velox/connectors/hive/iceberg/CMakeLists.txt

@@ -20,15 +20,6 @@ velox_add_library(
   IcebergSplitReader.cpp
   PartitionSpec.cpp
   PositionalDeleteFileReader.cpp
-  TransformEvaluator.cpp
-  TransformExprBuilder.cpp
-)
-
-velox_link_libraries(
-  velox_hive_iceberg_splitreader
-  velox_connector
-  velox_functions_iceberg
-  Folly::folly
 )
 
 velox_link_libraries(velox_hive_iceberg_splitreader velox_connector Folly::folly)

velox/connectors/hive/iceberg/IcebergDataSink.cpp

@@ -19,14 +19,6 @@
 
 namespace facebook::velox::connector::hive::iceberg {
 
-void registerIcebergInternalFunctions(const std::string_view& prefix) {
-  static std::once_flag registerFlag;
-
-  std::call_once(registerFlag, [prefix]() {
-    functions::iceberg::registerFunctions(std::string(prefix));
-  });
-}
-
 IcebergInsertTableHandle::IcebergInsertTableHandle(
     std::vector<HiveColumnHandlePtr> inputColumns,
     LocationHandlePtr locationHandle,
@@ -65,11 +57,7 @@ IcebergDataSink::IcebergDataSink(
           commitStrategy,
           hiveConfig,
           0,
-          nullptr) {
-  static constexpr std::string_view kDefaultIcebergFunctionPrefix{
-      "$internal$.iceberg."};
-  registerIcebergInternalFunctions(kDefaultIcebergFunctionPrefix.data());
-}
+          nullptr) {}
 
 std::vector<std::string> IcebergDataSink::commitMessage() const {
   std::vector<std::string> commitTasks;

velox/connectors/hive/iceberg/IcebergDataSink.h

@@ -18,16 +18,9 @@
 
 #include "velox/connectors/hive/HiveDataSink.h"
 #include "velox/connectors/hive/iceberg/PartitionSpec.h"
-#include "velox/functions/iceberg/Register.h"
 
 namespace facebook::velox::connector::hive::iceberg {
 
-/// Registers Iceberg partition transform functions with prefix.
-/// NOTE: These functions are registered for internal transform usage only.
-/// Upstream engines such as Prestissimo and Gluten should register the same
-/// functions with different prefixes to avoid conflicts.
-void registerIcebergInternalFunctions(const std::string_view& prefix);
-
 /// Represents a request for Iceberg write.
 class IcebergInsertTableHandle final : public HiveInsertTableHandle {
  public:

velox/connectors/hive/iceberg/PartitionSpec.h

@@ -113,7 +113,6 @@ struct IcebergPartitionSpec {
         case TransformType::kTruncate:
           return type;
       }
-      VELOX_UNREACHABLE("Unknown transform type");
     }
   };
 

velox/connectors/hive/iceberg/TransformEvaluator.cpp

@@ -64,7 +64,6 @@ if(NOT VELOX_DISABLE_GOOGLETEST)
     IcebergTestBase.cpp
     Main.cpp
     PartitionSpecTest.cpp
-    TransformTest.cpp
   )
 
   add_test(velox_hive_iceberg_insert_test velox_hive_iceberg_insert_test)