[BUG] Previous `edit` will draw cursor after switching focus to another `edit` in a different window

[PavelSharp]

As mentioned in comment Nuklear still has a bug when switching focus between two edits(include properties) that belong to different windows. At the moment, the previous edit will continue to draw the caret, but keyboard input is also affected, the edit that receives input depends on which one the mouse cursor is currently hovering over.
Note: This only happens when switching between different windows, not when switching between edits inside the same window.
For more information, see the attached screenshot (tested with SDL2)

[sleeptightAnsiC]

See: #852 (comment) (it describes the same issue, nothing really new)

Edit selection is also a problem, but I'm not sure how to deal with it. Terminals seem to be ignoring it entirely:

SCREENSHOT

[sleeptightAnsiC]

Strange, this thing should at least change the color depending on state:

REFERENCE

Nuklear/src/nuklear_edit.c

Lines 530 to 552 in 4aff9c7

	/* select correct colors to draw */
	if (*state & NK_WIDGET_STATE_ACTIVED) {
	background = &style->active;
	text_color = style->text_active;
	sel_text_color = style->selected_text_hover;
	sel_background_color = style->selected_hover;
	cursor_color = style->cursor_hover;
	cursor_text_color = style->cursor_text_hover;
	} else if (*state & NK_WIDGET_STATE_HOVER) {
	background = &style->hover;
	text_color = style->text_hover;
	sel_text_color = style->selected_text_hover;
	sel_background_color = style->selected_hover;
	cursor_text_color = style->cursor_text_hover;
	cursor_color = style->cursor_hover;
	} else {
	background = &style->normal;
	text_color = style->text_normal;
	sel_text_color = style->selected_text_normal;
	sel_background_color = style->selected_normal;
	cursor_color = style->cursor_normal;
	cursor_text_color = style->cursor_text_normal;
	}

At first, I thought, it's just a problem of having the same color (white) for both states, but even after trying to change them, it always uses the "hovered" one.

SCREENSHOT 1

The logic whether or not this thing is being hovered is broken. I was able to make it somewhat working with...

PATCH

diff --git a/src/nuklear_edit.c b/src/nuklear_edit.c
index ae5daed..f8b9f86 100644
--- a/src/nuklear_edit.c
+++ b/src/nuklear_edit.c
@@ -311,11 +311,11 @@ nk_do_edit(nk_flags *state, struct nk_command_buffer *out,
     }
 
     /* set widget state */
-    if (edit->active)
+    if (edit->active && in)
         *state = NK_WIDGET_STATE_ACTIVE;
     else nk_widget_state_reset(state);
 
-    if (is_hovered)
+    if (is_hovered && in)
         *state |= NK_WIDGET_STATE_HOVERED;
 
     /* DRAW EDIT */
@@ -618,7 +618,12 @@ nk_do_edit(nk_flags *state, struct nk_command_buffer *out,
                 cursor.x = area.x + cursor_pos.x - edit->scrollbar.x;
                 cursor.y = area.y + cursor_pos.y + row_height/2.0f - cursor.h/2.0f;
                 cursor.y -= edit->scrollbar.y;
-                nk_fill_rect(out, cursor, 0, cursor_color);
+                if (*state & NK_WIDGET_STATE_ACTIVE) {
+                    nk_fill_rect(out, cursor, 0, cursor_color);
+                } else {
+                    /* FIXME: does line_thickness=2 make sense ? */
+                    nk_stroke_rect(out, cursor, 0, 2, cursor_color);
+                }
             } else {
                 /* draw cursor inside text */
                 int glyph_len;
@@ -637,6 +642,7 @@ nk_do_edit(nk_flags *state, struct nk_command_buffer *out,
                 txt.padding = nk_vec2(0,0);
                 txt.background = cursor_color;;
                 txt.text = cursor_text_color;
+                /* FIXME: should I also conditionally use nk_stroke_rect here ?? */
                 nk_fill_rect(out, label, 0, cursor_color);
                 nk_widget_text(out, label, cursor_ptr, glyph_len, &txt, NK_TEXT_LEFT, font);
             }

...but this still doesn't seem very right to me, and I don't consider it correct.

The fact that this function has different branches for the active and the hovered states is also quite strange. It seems like it will misbehave when active != hovered, and it just happens to work because default theme uses the same color for all of them.

Anyway, this whole code is just bonkers, but my patch from above makes it somewhat behave as expected:

SCREENSHOT 2