fix ut

Author: YanhuiDua

tests/ray/test_evaluator.py

@@ -107,20 +107,6 @@ def custom_compute_metric(samples):
         custom_evaluator = Evaluator.remote(custom_evaluator_cfg, self.test_env)
         custom_correctness = ray.get(custom_evaluator.run.remote())
         self.assertEqual(correctness['accuracy'], custom_correctness['custom_accuracy'])
-
-    @unittest.skipIf(os.environ.get("XTUNER_USE_LMDEPLOY", "0") == "0", "lmdeploy backend is not enabled")
-    def test_lmdeploy_evaluator_with_failed_response(self):
-        evaluator_cfg = EvaluatorConfig(
-            dataset_cfg=self.eval_dataset_cfg,
-            tokenizer=self.tokenizer,
-            max_concurrent=1,
-            eval_sample_ratio=1,  # generate 5 samples
-            sample_params=SampleParams(temperature=2.5),  # invalid temperature to trigger error
-            max_retry_times=1,
-        )
-        evaluator = Evaluator.remote(evaluator_cfg, self.test_env)
-        correctness = ray.get(evaluator.run.remote())
-        self.assertEqual(len(correctness), 0)
 
 if __name__ == '__main__':
     unittest.main()

tests/ray/test_mock_rollout.py

@@ -25,22 +25,19 @@
 @ray.remote
 class MockTimeoutRolloutController(RolloutController):
     def _get_worker_cls(self):
-        return MockTimeoutRolloutWorker
-
+        return ray.remote(MockTimeoutRolloutWorker)
 @ray.remote
 class MockRequestErrorRolloutController(RolloutController):
     def _get_worker_cls(self):
-        return MockRequestErrorRolloutWorker
-
+        return ray.remote(MockRequestErrorRolloutWorker)
 @ray.remote
 class MockClientErrorRolloutController(RolloutController):
     def _get_worker_cls(self):
-        return MockClientErrorRolloutWorker
-
+        return ray.remote(MockClientErrorRolloutWorker)
 @ray.remote
 class MockServerErrorRolloutController(RolloutController):
     def _get_worker_cls(self):
-        return MockServerErrorRolloutWorker
+        return ray.remote(MockServerErrorRolloutWorker)
 
 class TestMockRollout(unittest.TestCase):
     @classmethod
@@ -103,7 +100,7 @@ def tearDown(self):
         ray.shutdown()
 
     def _run_mock_test(self, mock_controller_cls, error_name: str):
-        rollout_controller = ray.remote(mock_controller_cls).remote(self.rollout_cfg, self.pg)
+        rollout_controller = mock_controller_cls.remote(self.rollout_cfg, self.pg)
         self.test_env = SingleTurnEnvironment.remote("env", self.pg, self.rollout_cfg, rollout_controller=rollout_controller)
         self.test_dataflow = DataFlow.remote("dataflow", self.dataflow_cfg, self.replay_buffer_cfg, self.test_env)