fix comments

Author: YanhuiDua

tests/ray/test_mock_rollout.py

@@ -16,7 +16,6 @@
 
 MODEL_PATH = os.environ["ROLLOUT_MODEL_PATH"] 
 TRAIN_DATA_PATH = os.environ["ROLLOUT_DATA_PATH"]
-TEST_DATA_PATH = os.environ["ROLLOUT_DATA_PATH"]
 resource_map = {"npu": "NPU", "cuda": "GPU"}
 
 @ray.remote

xtuner/v1/ray/environment/single_turn_env.py

@@ -30,6 +30,8 @@ class SingleTurnEnvironment(BaseEnvironment):
         judger_pg (Any): The placement group for scheduling judger Ray actors.
                          Defaults to None indicates using the rollout_pg.
         judger_cfg (optional): Configuration for the judger controller. Defaults to None.
+        rollout_controller (optional): An instance of the rollout controller. Defaults to None.
+        judger_controller (optional): An instance of the judger controller. Defaults to None.
     """
 
     def __init__(

xtuner/v1/ray/rollout/controller.py

@@ -269,9 +269,10 @@ def deactivate_worker_by_url(self, url):
                 f"Rollout worker {url} failed {self.url_failed_counts[url]} times, but not deactivated yet."
             )
             return
-        self.logger.error(f"Deactivating rollout worker {url} due to repeated failures.")
         inactive_workers = self.active_url_to_workers.get(url)
-        self.active_workers_to_status[inactive_workers] = False
+        if inactive_workers:
+            self.logger.warning(f"Deactivating rollout worker {url} due to repeated failures.")
+            self.active_workers_to_status[inactive_workers] = False
 
     async def rollout(
         self,

xtuner/v1/utils/httpx_utils.py

@@ -1,3 +1,4 @@
+import copy
 import traceback
 from dataclasses import dataclass, field
 from enum import IntEnum
@@ -80,8 +81,10 @@ def __post_init__(self):
         error_msg is not already set."""
         # Only generate a message if one hasn't been provided already.
         if self.error_msg is None and self.error_type != HttpRequestErrorType.SUCCESS:
+            log_payload = {}
             if self.payload is not None and "input_ids" in self.payload:
-                self.payload["input_ids"] = str(self.payload["input_ids"])
+                log_payload = copy.deepcopy(self.payload)
+                log_payload["input_ids"] = str(log_payload["input_ids"])
 
             default_messages = {
                 HttpRequestErrorType.UNKNOWN_ERROR: f"An unknown error {self.exception} occurred, Traceback: {traceback.format_exc()}",
@@ -105,7 +108,7 @@ def __post_init__(self):
             )
             if self.error_type == HttpRequestErrorType.REQUEST_ERROR and self.exception:
                 if hasattr(self.exception, "__cause__") and self.exception.__cause__:
-                    self.error_msg += f"__cause__: {self.exception.__cause__}"
+                    self.error_msg += f" __cause__: {self.exception.__cause__}"
 
     @property
     def is_success(self) -> bool: