- from_timestamp parameter has now a default value of 0 which means scan

  all the commits

Author: Gal Ben David

setup.py

@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name='PyRepScan',
-    version='0.5.1',
+    version='0.5.2',
     author='Gal Ben David',
     author_email='[email protected]',
     url='https://github.com/intsights/PyRepScan',

src/git_repository_scanner.cpp

@@ -59,14 +59,20 @@ class GitRepositoryScanner {
         git_revwalk_sorting(repo_revwalk, GIT_SORT_TIME);
         git_revwalk_push_glob(repo_revwalk, branch_glob_pattern.c_str());
 
-        git_commit * current_commit = nullptr;
-        while (git_revwalk_next(&oid, repo_revwalk) == 0) {
-            git_commit_lookup(&current_commit, git_repo, &oid);
-            git_time_t commit_time = git_commit_time(current_commit);
-            if (commit_time >= from_timestamp) {
+        if (from_timestamp == 0) {
+            while (git_revwalk_next(&oid, repo_revwalk) == 0) {
                 oids.push_back(oid);
             }
-            git_commit_free(current_commit);
+        } else {
+            git_commit * current_commit = nullptr;
+            while (git_revwalk_next(&oid, repo_revwalk) == 0) {
+                git_commit_lookup(&current_commit, git_repo, &oid);
+                git_time_t commit_time = git_commit_time(current_commit);
+                if (commit_time >= from_timestamp) {
+                    oids.push_back(oid);
+                }
+                git_commit_free(current_commit);
+            }
         }
 
         git_revwalk_free(repo_revwalk);
@@ -322,7 +328,7 @@ PYBIND11_MODULE(pyrepscan, m) {
             "Scan a repository for secrets",
             pybind11::arg("repository_path"),
             pybind11::arg("branch_glob_pattern"),
-            pybind11::arg("from_timestamp")
+            pybind11::arg("from_timestamp") = 0
         )
         .def(
             "add_rule",

tests/test_pyrepscan.py

@@ -477,7 +477,6 @@ def test_scan_regular(
         results = grs.scan(
             repository_path=self.tmpdir.name,
             branch_glob_pattern='*master',
-            from_timestamp=0,
         )
         for result in results:
             result.pop('commit_id')
@@ -520,7 +519,6 @@ def test_scan_regular(
         results = grs.scan(
             repository_path=self.tmpdir.name,
             branch_glob_pattern='*',
-            from_timestamp=0,
         )
         for result in results:
             result.pop('commit_id')
@@ -660,72 +658,3 @@ def test_scan_from_timestamp(
             list1=results,
             list2=[],
         )
-
-    def test_scan_encoding(
-        self,
-    ):
-        grs = pyrepscan.GitRepositoryScanner()
-        grs.add_rule(
-            name='First Rule',
-            match_pattern=r'''(content)''',
-            match_whitelist_patterns=[],
-            match_blacklist_patterns=[],
-        )
-
-        grs.add_ignored_file_extension('py')
-        grs.add_ignored_file_path('test_')
-
-        results = grs.scan(
-            repository_path=self.tmpdir.name,
-            branch_glob_pattern='*',
-            from_timestamp=int(
-                datetime.datetime(
-                    year=2004,
-                    month=1,
-                    day=1,
-                    hour=0,
-                    minute=0,
-                    second=0,
-                    tzinfo=datetime.timezone.utc,
-                ).timestamp()
-            ),
-        )
-        for result in results:
-            result.pop('commit_id')
-        self.assertCountEqual(
-            first=results,
-            second=[
-                {
-                    'author_email': '[email protected]',
-                    'author_name': 'Author Name',
-                    'commit_message': 'edited file in non_merged_branch',
-                    'commit_time': '2004-01-01T00:00:00',
-                    'file_oid': '057032a2108721ad1de6a9240fd1a8f45bc3f2ef',
-                    'file_path': 'file.txt',
-                    'match': 'content',
-                    'rule_name': 'First Rule'
-                },
-            ],
-        )
-
-        results = grs.scan(
-            repository_path=self.tmpdir.name,
-            branch_glob_pattern='*',
-            from_timestamp=int(
-                datetime.datetime(
-                    year=2004,
-                    month=1,
-                    day=1,
-                    hour=0,
-                    minute=0,
-                    second=1,
-                    tzinfo=datetime.timezone.utc,
-                ).timestamp()
-            ),
-        )
-        for result in results:
-            result.pop('commit_id')
-        self.assertListEqual(
-            list1=results,
-            list2=[],
-        )