Add ability to open pdfs in standalone nad gui mode

Author: palukku

jabls/src/main/java/org/jabref/languageserver/BibtexTextDocumentService.java

@@ -94,9 +94,6 @@ public void didSave(DidSaveTextDocumentParams params) {
 
     @Override
     public CompletableFuture<Either<List<? extends Location>, List<? extends LocationLink>>> definition(DefinitionParams params) {
-        if (!clientHandler.isStandalone()) {
-            return CompletableFuture.completedFuture(Either.forLeft(List.of()));
-        }
         if (fileUriToLanguageId.containsKey(params.getTextDocument().getUri())) {
             String fileUri = params.getTextDocument().getUri();
             return linkHandler.provideDefinition(fileUriToLanguageId.get(fileUri), fileUri, contentCache.get(fileUri), params.getPosition());
@@ -106,9 +103,6 @@ public CompletableFuture<Either<List<? extends Location>, List<? extends Locatio
 
     @Override
     public CompletableFuture<List<DocumentLink>> documentLink(DocumentLinkParams params) {
-        if (clientHandler.isStandalone()) {
-            return CompletableFuture.completedFuture(List.of());
-        }
         String fileUri = params.getTextDocument().getUri();
         return linkHandler.provideDocumentLinks(fileUri, fileUriToLanguageId.get(fileUri), contentCache.get(fileUri));
     }

jabls/src/main/java/org/jabref/languageserver/LspClientHandler.java

@@ -45,7 +45,7 @@ public LspClientHandler(RemoteMessageHandler messageHandler, CliPreferences cliP
         this.settings = ExtensionSettings.getDefaultSettings();
         this.parserHandler = new LspParserHandler();
         this.diagnosticHandler = new LspDiagnosticHandler(this, parserHandler, cliPreferences, abbreviationRepository);
-        this.linkHandler = new LspLinkHandler(parserHandler, cliPreferences);
+        this.linkHandler = new LspLinkHandler(this, parserHandler, cliPreferences);
         this.workspaceService = new BibtexWorkspaceService(this, diagnosticHandler);
         this.textDocumentService = new BibtexTextDocumentService(messageHandler, this, diagnosticHandler, linkHandler);
         this.messageHandler = messageHandler;

jabls/src/main/java/org/jabref/languageserver/util/LspIntegrityCheck.java

@@ -44,7 +44,7 @@ public List<Diagnostic> check(ParserResult parserResult) {
                     }
                 });
             } catch (NullPointerException nullPointerException) {
-                LOGGER.error("Error while performing integrity check.", nullPointerException);
+                LOGGER.debug("Error while performing integrity check.", nullPointerException);
             }
             return Stream.of();
         }).toList();

jabls/src/main/java/org/jabref/languageserver/util/LspLinkHandler.java

@@ -4,6 +4,7 @@
 import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
 
+import org.jabref.languageserver.LspClientHandler;
 import org.jabref.languageserver.util.definition.DefinitionProvider;
 import org.jabref.languageserver.util.definition.DefinitionProviderFactory;
 import org.jabref.logic.preferences.CliPreferences;
@@ -20,15 +21,21 @@ public class LspLinkHandler {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(LspLinkHandler.class);
 
+    private final LspClientHandler clientHandler;
     private final LspParserHandler parserHandler;
     private final CliPreferences preferences;
 
-    public LspLinkHandler(LspParserHandler parserHandler, CliPreferences preferences) {
+    public LspLinkHandler(LspClientHandler clientHandler, LspParserHandler parserHandler, CliPreferences preferences) {
+        this.clientHandler = clientHandler;
         this.parserHandler = parserHandler;
         this.preferences = preferences;
     }
 
     public CompletableFuture<Either<List<? extends Location>, List<? extends LocationLink>>> provideDefinition(String languageId, String uri, String content, Position position) {
+        if (!clientHandler.isStandalone() && !"bibtex".equals(languageId)) {
+            return CompletableFuture.completedFuture(Either.forLeft(List.of()));
+        }
+
         List<Location> locations = List.of();
         Optional<DefinitionProvider> provider = DefinitionProviderFactory.getDefinitionProvider(preferences, parserHandler, languageId);
         if (provider.isPresent()) {
@@ -39,6 +46,9 @@ public CompletableFuture<Either<List<? extends Location>, List<? extends Locatio
     }
 
     public CompletableFuture<List<DocumentLink>> provideDocumentLinks(String fileUri, String languageId, String content) {
+        if (clientHandler.isStandalone()) {
+            return CompletableFuture.completedFuture(List.of());
+        }
         List<DocumentLink> documentLinks = List.of();
         Optional<DefinitionProvider> provider = DefinitionProviderFactory.getDefinitionProvider(preferences, parserHandler, languageId);
         if (provider.isPresent()) {

jabls/src/main/java/org/jabref/languageserver/util/definition/BibDefinitionProvider.java

@@ -72,7 +72,7 @@ public List<Location> provideDefinition(String uri, String content, Position pos
                             Optional<Path> filePath = FileUtil.find(parserResult.get().getDatabaseContext(), linkedFile.getLink(), preferences.getFilePreferences());
                             return List.of(new Location(filePath.get().toUri().toString(), EMPTY_RANGE));
                         } catch (NullPointerException e) {
-                            LOGGER.error("Error while getting file path", e);
+                            LOGGER.debug("Error while getting file path", e);
                         }
                     }
                 }
@@ -81,6 +81,7 @@ public List<Location> provideDefinition(String uri, String content, Position pos
         return List.of();
     }
 
+    // Not needed when trying to resolve links to pdfs
     @Override
     public List<DocumentLink> provideDocumentLinks(String fileUri, String content) {
         return List.of();