diff --git a/CHANGELOG.md b/CHANGELOG.md index 04b790270e1..5b45cc2e342 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We separated the "Clean up entries" dialog into three tabs for clarity [#13819](https://github.com/JabRef/jabref/issues/13819) - `JabKit`: `--porcelain` does not output any logs to the console anymore. [#14244](https://github.com/JabRef/jabref/pull/14244) - Ctrl + Shift + L now opens the terminal in the active library directory. [#14130](https://github.com/JabRef/jabref/issues/14130) +- We changed fixed-value ComboBoxes to SearchableComboBox for better usability. [#14083](https://github.com/JabRef/jabref/issues/14083) ### Fixed diff --git a/jabgui/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneView.java b/jabgui/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneView.java index d5347ccc061..53b2c09f492 100644 --- a/jabgui/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneView.java +++ b/jabgui/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneView.java @@ -5,7 +5,6 @@ import javafx.beans.value.ObservableBooleanValue; import javafx.css.PseudoClass; import javafx.scene.control.Button; -import javafx.scene.control.ComboBox; import javafx.scene.control.TextField; import javafx.scene.control.Tooltip; import javafx.scene.input.KeyCode; @@ -27,6 +26,7 @@ import org.jabref.logic.l10n.Localization; import com.tobiasdiez.easybind.EasyBind; +import org.controlsfx.control.SearchableComboBox; public class WebSearchPaneView extends VBox { @@ -84,8 +84,8 @@ private void addQueryValidationHints(TextField query) { /** * Create combo box for selecting fetcher */ - private ComboBox createFetcherComboBox() { - ComboBox fetchers = new ComboBox<>(); + private SearchableComboBox createFetcherComboBox() { + SearchableComboBox fetchers = new SearchableComboBox<>(); new ViewModelListCellFactory() .withText(SearchBasedFetcher::getName) .install(fetchers); diff --git a/jabgui/src/main/java/org/jabref/gui/preferences/external/ExternalTab.java b/jabgui/src/main/java/org/jabref/gui/preferences/external/ExternalTab.java index 7f3c34c368b..cfea969d701 100644 --- a/jabgui/src/main/java/org/jabref/gui/preferences/external/ExternalTab.java +++ b/jabgui/src/main/java/org/jabref/gui/preferences/external/ExternalTab.java @@ -4,7 +4,6 @@ import javafx.fxml.FXML; import javafx.scene.control.Button; import javafx.scene.control.CheckBox; -import javafx.scene.control.ComboBox; import javafx.scene.control.TextField; import org.jabref.gui.actions.ActionFactory; @@ -20,12 +19,13 @@ import com.airhacks.afterburner.views.ViewLoader; import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer; +import org.controlsfx.control.SearchableComboBox; public class ExternalTab extends AbstractPreferenceTabView implements PreferencesTab { @FXML private TextField eMailReferenceSubject; @FXML private CheckBox autoOpenAttachedFolders; - @FXML private ComboBox pushToApplicationCombo; + @FXML private SearchableComboBox pushToApplicationCombo; @FXML private TextField citeCommand; @FXML private Button autolinkExternalHelp; diff --git a/jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java b/jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java index 50b3023808a..2ec82e3c46d 100644 --- a/jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java +++ b/jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java @@ -32,10 +32,11 @@ import com.tobiasdiez.easybind.EasyBind; import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer; import jakarta.inject.Inject; +import org.controlsfx.control.SearchableComboBox; public class GeneralTab extends AbstractPreferenceTabView implements PreferencesTab { - @FXML private ComboBox language; + @FXML private SearchableComboBox language; @FXML private ComboBox theme; @FXML private CheckBox themeSyncOs; @FXML private TextField customThemePath; diff --git a/jabgui/src/main/resources/org/jabref/gui/preferences/external/ExternalTab.fxml b/jabgui/src/main/resources/org/jabref/gui/preferences/external/ExternalTab.fxml index 8db73e2b093..7a1886cb1c5 100644 --- a/jabgui/src/main/resources/org/jabref/gui/preferences/external/ExternalTab.fxml +++ b/jabgui/src/main/resources/org/jabref/gui/preferences/external/ExternalTab.fxml @@ -2,7 +2,6 @@ - @@ -12,6 +11,7 @@ + @@ -41,8 +41,8 @@