Feat: Add the ability to open linked pdf files in bib files #14275
Conversation
palukku
changed the title
| // We need state to have a more clean code. Thus, we instantiate the class and then return the result | ||
| FileFieldParser fileFieldParser = new FileFieldParser(value); | ||
| return fileFieldParser.parse(); | ||
| return new ArrayList<>(fileFieldParser.parse().stream().map(LinkedFilePosition::linkedFile).toList()); |
There was a problem hiding this comment.
To create a modifiable list, the usual way is with .collect(Colltectors.toList()) (or similar).
Also add to JavaDoc that the list is modifiable.
However - why do you need the result be modifiable? I think, the caller should convert it to a modifiable list (I might be wrong here, did not check all the code, but only thought of parsing and that the parsed representation should be read-only, because the underlying thing does not change)
| @Override | ||
| public List<DocumentLink> provideDocumentLinks(String fileUri, String content) { | ||
| return List.of(); | ||
| } |
There was a problem hiding this comment.
yes because this is only relevant (for now) when we want to execute commands or do stuff in the ui, but pdf opening is (currently) only for opening them in vscode and therefore we dont need this
palukku
force-pushed
the
add-pdf-open
branch
from
6bb6c17 to
8d07104
Compare
|
sorry for force pushing, but I accidentally re ordered a commit in gitbutler and than reversed it to the original state, but because of gitbutlerapp/gitbutler#10266 I needed to force push in order to get it working... |
InAnYan
left a comment
InAnYan
left a comment
There was a problem hiding this comment.
I can confirm that with absolute paths it works.
Though, from the UI side, I don't like, that it underscores only a single word, not a full URL, but for now ça suffit
But this is from VSCodes side, i set the range for the link to the whole file. The hyperlink view only works for documentLinks, maybe it could be reworked to use DocumentLinks |
| """, | ||
| importFormatPreferences); | ||
| List<LinkedFile> files = parserResult.getDatabaseContext().getEntries().getFirst().getFiles(); | ||
| assertNotNull(files.getLast().getLink()); |
There was a problem hiding this comment.
I would prefer an assertEquals here, if possible
There was a problem hiding this comment.
Shouldnt you also check for two occurrences?
5 participants
Closes palukku#32
Adds the ability to ctrl + click on a linked pdf if the path is absolute and opens it in vscode (if pdf preview extension is installed)
Steps to test
Start JabLs from this branch and than vscode with the extension enabled.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)