Skip to content

Commit bcb02f7

Browse files
danilojslDevinTDHa
authored andcommitted
Remobing logging trait
1 parent f50eba3 commit bcb02f7

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/main/scala/com/johnsnowlabs/nlp/ParamsAndFeaturesReadable.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ import scala.util.{Failure, Success, Try}
3131
class FeaturesReader[T <: HasFeatures](
3232
baseReader: MLReader[T],
3333
onRead: (T, String, SparkSession) => Unit)
34-
extends MLReader[T]
35-
with Logging {
34+
extends MLReader[T] {
3635

3736
override def load(path: String): T = {
3837

src/test/scala/com/johnsnowlabs/nlp/annotators/er/EntityRulerTest.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,7 @@ class EntityRulerTest extends AnyFlatSpec with SparkSessionTest {
851851
}
852852

853853
it should "serialize EntityRulerModel" taggedAs SlowTest in {
854-
//Should br run with Java 8 and Scala 2.12
854+
//Should be run with Java 8 and Scala 2.12
855855
val entityRuler = new EntityRulerApproach()
856856
.setInputCols("document", "token")
857857
.setOutputCol("entities")
@@ -861,7 +861,7 @@ class EntityRulerTest extends AnyFlatSpec with SparkSessionTest {
861861
entityRulerModel.write.overwrite().save("./tmp_entity_ruler_model_java8_scala2_12")
862862
}
863863

864-
it should "deserialize EntityRulerModel" in {
864+
it should "deserialize EntityRulerModel" taggedAs SlowTest in {
865865
val textDataSet = Seq(text1).toDS.toDF("text")
866866
val loadedEntityRulerModel = EntityRulerModel.load("./tmp_entity_ruler_model_java8_scala2_12")
867867

0 commit comments

Comments
 (0)