Skip to content

Commit d7e4dca

Browse files
authored
Fix SQS tests assuming the query service response structure (#684)
* Fix SQS tests assuming the query service response structure In PR 637, SQS changed from a `QueryService` to a `JSONService`. The response obtained when interacting with SQS using the query protocol includes a field called `<ActionName>Result`, where `<ActionName>` is the action requested. The JSON protocol does not include that field. Thus we can fix issue 683 by simply deleting that additional `getindex` call. * Also remove `ReceiveMessageResult` * Helps if you read the docs * Once again, the docs help * ...And again, docs
1 parent 162c608 commit d7e4dca

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/AWS.jl

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,7 @@ end
792792
function _get_queue_url(queue_name)
793793
result = SQS.get_queue_url(queue_name)
794794

795-
return result["GetQueueUrlResult"]["QueueUrl"]
795+
return result["QueueUrl"]
796796
end
797797

798798
# Create Queue
@@ -809,7 +809,7 @@ end
809809
SQS.send_message(expected_message, queue_url)
810810

811811
response = SQS.receive_message(queue_url)
812-
receipt_handle = response["ReceiveMessageResult"]["Message"]["ReceiptHandle"]
812+
receipt_handle = only(response["Messages"])["ReceiptHandle"]
813813

814814
response = SQS.delete_message_batch(
815815
[
@@ -820,13 +820,13 @@ end
820820
queue_url,
821821
)
822822

823-
message_id = response["DeleteMessageBatchResult"]["DeleteMessageBatchResultEntry"]["Id"]
823+
message_id = only(response["Successful"])["Id"]
824824
@test message_id == expected_message_id
825825

826826
SQS.send_message(expected_message, queue_url)
827827

828828
result = SQS.receive_message(queue_url)
829-
message = result["ReceiveMessageResult"]["Message"]["Body"]
829+
message = only(result["Messages"])["Body"]
830830
@test message == expected_message
831831
finally
832832
SQS.delete_queue(queue_url)
@@ -842,7 +842,7 @@ end
842842
function _get_queue_url(queue_name)
843843
result = AWSServices.sqs("GetQueueUrl", LittleDict("QueueName" => queue_name))
844844

845-
return result["GetQueueUrlResult"]["QueueUrl"]
845+
return result["QueueUrl"]
846846
end
847847

848848
# Create Queue
@@ -863,13 +863,13 @@ end
863863
response = AWSServices.sqs(
864864
"ReceiveMessage", LittleDict("QueueUrl" => queue_url)
865865
)
866-
receipt_handle = response["ReceiveMessageResult"]["Message"]["ReceiptHandle"]
866+
receipt_handle = only(response["Messages"])["ReceiptHandle"]
867867

868868
response = AWSServices.sqs(
869869
"DeleteMessageBatch",
870870
LittleDict(
871871
"QueueUrl" => queue_url,
872-
"DeleteMessageBatchRequestEntry" => [
872+
"Entries" => [
873873
LittleDict(
874874
"Id" => expected_message_id,
875875
"ReceiptHandle" => receipt_handle,
@@ -878,7 +878,7 @@ end
878878
),
879879
)
880880

881-
message_id = response["DeleteMessageBatchResult"]["DeleteMessageBatchResultEntry"]["Id"]
881+
message_id = only(response["Successful"])["Id"]
882882
@test message_id == expected_message_id
883883

884884
# Send message
@@ -889,7 +889,7 @@ end
889889

890890
# Receive Message
891891
result = AWSServices.sqs("ReceiveMessage", LittleDict("QueueUrl" => queue_url))
892-
message = result["ReceiveMessageResult"]["Message"]["Body"]
892+
message = only(result["Messages"])["Body"]
893893
@test message == expected_message
894894
finally
895895
AWSServices.sqs("DeleteQueue", LittleDict("QueueUrl" => queue_url))

0 commit comments

Comments
 (0)