Skip to content

Commit a60f302

Browse files
Don't treat Q's like easily readable arrays (#725)
* Don't treat Q's like easily readable arrays * Apply suggestions from code review Co-authored-by: Daniel Karrasch <[email protected]> Co-authored-by: Fredrik Bagge Carlson <[email protected]>
1 parent f5e0887 commit a60f302

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/analysis.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ function tzeros(A::AbstractMatrix{T}, B::AbstractMatrix{T}, C::AbstractMatrix{T}
235235
# Step 3:
236236
# Compress cols of [C D] to [0 Df]
237237
mat = [C_rc D_rc]
238-
Wr = qr(mat').Q
238+
Wr = qr(mat').Q * I
239239
W = reverse(Wr, dims=2)
240240
mat = mat*W
241241
if fastrank(mat', meps) > 0
@@ -277,7 +277,7 @@ function reduce_sys(A::AbstractMatrix, B::AbstractMatrix, C::AbstractMatrix, D::
277277
end
278278

279279
# Compress columns of Ctilde
280-
V = reverse(qr(Ctilde').Q, dims=2)
280+
V = reverse(qr(Ctilde').Q * I, dims=2)
281281
Sj = Ctilde*V
282282
rho = fastrank(Sj', meps)
283283
nu = size(Sj, 2) - rho

0 commit comments

Comments
 (0)