Skip to content

Conversation

@GabrielMajeri
Copy link
Contributor

Closes #251 by implementing a new interactive_clicker function. It works similar to interactive_poincaresos, but for an arbitrary 2D dynamical system (e.g. ProjectedDynamicalSystems).

@GabrielMajeri
Copy link
Contributor Author

The CI failure seems to be unrelated to the change.

When trying to run docs/make.jl locally, I run into the issue described here.

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the PR!

scatterkwargs = (),
labels = ("x", "y")
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you check here that dimension(dds) == 2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because this function can be used with higher-dimensional dynamical systems, as long as the complete and project parameters are properly defined. Adding such a check would break the use of this in interactive_poincaresos.

interactive_poincaresos_scan(trs, j; linekw = (transparency = true,))
```

## Interactive projected dynamical system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, to be clear: this works for any 2D system, right? This should be 2D maps, projected 2D systems, poincare maps, whatever. Right? If so, do we even need the interactive poincare map function anymore?

Additionally please rename this section to reflect the generality of the function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the docs.

If so, do we even need the interactive poincare map function anymore?

I don't know if we need it, but I think it's pretty useful (and one of the most common use cases, I believe). It would help from a backwards compatibility perspective to preserve the existing interactive_poincaresos API (even though now that function is now a wrapper for this one).

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GabrielMajeri , sorry that I took so long to return here. I am a bit confused. Is this application for discrete time systems, continuous, or both?

@GabrielMajeri
Copy link
Contributor Author

Is this application for discrete time systems, continuous, or both?

It should work in principle with any kind of dynamical system, as long as its state space has/can be projected down to two dimensions.

I don't actually need this interactive_clicker method, I only needed to get the interactive_poincaresos method to work. But your idea of introducing this higher-level abstraction means that we can support both the existing interactive Poincare surface-of-section GUI and possibly a projected dynamical system interactive GUI (which I've included as an example in the docs). The code is written to be more generic.

@Datseris
Copy link
Member

Datseris commented Sep 8, 2025

Thanks a lot for the contribution @GabrielMajeri . I've altered the design here a bit. I simplified a lot the 2D clicker function by making the poincare function creating the projected system internally. Now the 2D clicker doesn't really do anything fancy and doesn't project the system state. As long as someone plugs in something that is 2D, it works. It also handles differently continuous time systems.

@Datseris Datseris merged commit d1bae2d into JuliaDynamics:main Sep 8, 2025
1 of 2 checks passed
@GabrielMajeri GabrielMajeri deleted the add-interactive-clicker branch September 12, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new GUI: 2D dynamical system "clicker" and trajectory evolver

2 participants