-
Notifications
You must be signed in to change notification settings - Fork 98
Implement interactive 2D dynamical system clicker #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interactive 2D dynamical system clicker #252
Conversation
|
The CI failure seems to be unrelated to the change. When trying to run |
Datseris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for the PR!
ext/src/clicker.jl
Outdated
| scatterkwargs = (), | ||
| labels = ("x", "y") | ||
| ) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you check here that dimension(dds) == 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because this function can be used with higher-dimensional dynamical systems, as long as the complete and project parameters are properly defined. Adding such a check would break the use of this in interactive_poincaresos.
docs/src/visualizations.md
Outdated
| interactive_poincaresos_scan(trs, j; linekw = (transparency = true,)) | ||
| ``` | ||
|
|
||
| ## Interactive projected dynamical system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, to be clear: this works for any 2D system, right? This should be 2D maps, projected 2D systems, poincare maps, whatever. Right? If so, do we even need the interactive poincare map function anymore?
Additionally please rename this section to reflect the generality of the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the docs.
If so, do we even need the interactive poincare map function anymore?
I don't know if we need it, but I think it's pretty useful (and one of the most common use cases, I believe). It would help from a backwards compatibility perspective to preserve the existing interactive_poincaresos API (even though now that function is now a wrapper for this one).
Datseris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GabrielMajeri , sorry that I took so long to return here. I am a bit confused. Is this application for discrete time systems, continuous, or both?
It should work in principle with any kind of dynamical system, as long as its state space has/can be projected down to two dimensions. I don't actually need this |
|
Thanks a lot for the contribution @GabrielMajeri . I've altered the design here a bit. I simplified a lot the 2D clicker function by making the poincare function creating the projected system internally. Now the 2D clicker doesn't really do anything fancy and doesn't project the system state. As long as someone plugs in something that is 2D, it works. It also handles differently continuous time systems. |
Closes #251 by implementing a new
interactive_clickerfunction. It works similar tointeractive_poincaresos, but for an arbitrary 2D dynamical system (e.g.ProjectedDynamicalSystems).