DynamicalSystemsVisualizations fails to precompile

[saipavanc]

Describe the bug
After installing DynamicalSystems in a clean environment it fails to precompile, the only module being DynamicalSystemsVisualizations, with the following message:

PkgPrecompileError: The following 1 direct dependency failed to precompile:

DynamicalSystemsVisualizations 

Failed to precompile DynamicalSystemsVisualizations [bf41aec9-21e8-5d35-8521-19f2dd369247] to "/home/__/.julia/compiled/v1.12/DynamicalSystemsVisualizations/jl_KEONMe".
ERROR: LoadError: invalid assignment to constant DynamicalSystemsVisualizations.subscript. This redefinition may be permitted using the `const` keyword.
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/DynamicalSystems/sv3mw/ext/DynamicalSystemsVisualizations.jl:14
 [2] include(mod::Module, _path::String)
   @ Base ./Base.jl:306
 [3] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
   @ Base ./loading.jl:2996
 [4] top-level scope
   @ stdin:5
 [5] eval(m::Module, e::Any)
   @ Core ./boot.jl:489
 [6] include_string(mapexpr::typeof(identity), mod::Module, code::String, filename::String)
   @ Base ./loading.jl:2842
 [7] include_string
   @ ./loading.jl:2852 [inlined]
 [8] exec_options(opts::Base.JLOptions)
   @ Base ./client.jl:315
 [9] _start()
   @ Base ./client.jl:550
in expression starting at /home/__/.julia/packages/DynamicalSystems/sv3mw/ext/DynamicalSystemsVisualizations.jl:1
in expression starting at stdin:

Package versions

Status `~/.julia/environments/v1.12/Manifest.toml`
  [f3fd9213] Attractors v1.30.1
  [608a59af] ChaosTools v3.5.1
  [ab4b797d] ComplexityMeasures v3.8.5
  [5732040d] DelayEmbeddings v2.9.0
  [61744808] DynamicalSystems v3.6.5
  [6e36e845] DynamicalSystemsBase v3.15.1
  [4665ce21] FractalDimensions v1.9.6
  [31e2f376] PredefinedDynamicalSystems v1.5.0
  [639c3291] RecurrenceAnalysis v2.1.2
  [40b095a5] StateSpaceSets v2.5.2
  [c804724b] TimeseriesSurrogates v2.8.0

I somehow made it work by defining the subscript as a constant, which does work I guess but shows this error:

No layout found but `createmissing` is false.

Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:44
 [2] get_layout_at!(gp::GridPosition; createmissing::Bool)
   @ GridLayoutBase ~/.julia/packages/GridLayoutBase/M1OdU/src/gridlayout.jl:1673
 [3] get_layout_at!
   @ ~/.julia/packages/GridLayoutBase/M1OdU/src/gridlayout.jl:1666 [inlined]
 [4] contents(g::GridSubposition; exact::Bool)
   @ GridLayoutBase ~/.julia/packages/GridLayoutBase/M1OdU/src/gridlayout.jl:1690
 [5] contents
   @ ~/.julia/packages/GridLayoutBase/M1OdU/src/gridlayout.jl:1689 [inlined]
 [6] content(g::GridSubposition)
   @ GridLayoutBase ~/.julia/packages/GridLayoutBase/M1OdU/src/gridlayout.jl:1704
 [7] top-level scope

[Datseris]

I assume this is for Julia v1.12?

[saipavanc]

Sorry for the delay, yes it is Julia 1.12.1

[hibiki-kato]

Hi, I looked at the following module in DynamicalSystems.jl/ext/DynamicalSystemsVisualizations.jl

module DynamicalSystemsVisualizations

using DynamicalSystems, Makie
using DynamicalSystemsBase.SciMLBase

include("src/utils.jl")
include("src/dynamicalsystemobservable.jl")
include("src/interactive_trajectory.jl")
include("src/cobweb.jl")
include("src/orbitdiagram.jl")
include("src/brainscan.jl")
include("src/2dclicker.jl")

subscript = DynamicalSystemsVisualizations.subscript

end

The final line

subscript = DynamicalSystemsVisualizations.subscript

appears in the commit e8f39af , but I’m unsure what the goal of that line is.

For comparison, the package Agents.jl has its extension AgentsVisualizations.jl, but it does not include a similar reassignment.
Could the line be safely removed altogether?

@saipavanc I cannot reproduce No layout found but `createmissing` is false. error. How did you find it?

[Datseris]

I dont understand what that line is doing either... Does compilation work if you remove it? Can you open a PR with that?

[hibiki-kato]

Yes, it works (I am experimentally using that version locally), but I'm not sure about its side effects.