Move properties from ProximalOperators to ProximalCore#5
Merged
lostella merged 10 commits intoJuliaFirstOrder:masterfrom Nov 19, 2025
hakkelt:master
Merged
Move properties from ProximalOperators to ProximalCore#5lostella merged 10 commits intoJuliaFirstOrder:masterfrom hakkelt:master
lostella merged 10 commits intoJuliaFirstOrder:masterfrom
hakkelt:master
Conversation
lostella
reviewed
Nov 12, 2025
lostella
reviewed
Nov 12, 2025
Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
Contributor
Author
|
Can this PR be merged, or is there anything I can do? |
lostella
requested changes
Nov 18, 2025
Member
|
@hakkelt so the overall plan is:
Is this accurate? |
Contributor
Author
|
Exactly |
Apply suggestions from code review Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
lostella
approved these changes
Nov 19, 2025
Contributor
Author
|
Thank you for the review! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves property functions (
is_smooth,is_convex,is_generalized_quadratic, etc.) from ProximalOperators to this package. Some of the functions are also renamed for clarity:is_singleton->is_singleton_indicatoris_cone->is_cone_indicatoris_affine->is_affine_indicatoris_set->is_set_indicatoris_prox_accurate->is_proximableMy goal with that change is that I can reference properties in ProximalAlgorithms such that it can be queried from StructuredOptimizations.jl, what properties are required for the given inputs. E.g.:
It allows StructuredOptimization to automatically parse problems for a given algorithm as
get_assumptionstells the name of the input (fandgin this case), and exposes enough information for decisions during parsing.