Test against unzip_jll (#36)

* use unzip_jll

* remove quiet flag

* remove other quiet flag

* fix typo

* Don't test unzip_jll on Windows

* add quiet flag

---------

Co-authored-by: Viral B. Shah <[email protected]>

Author: nhz2

.github/workflows/CI.yml

@@ -37,7 +37,7 @@ jobs:
             version: '1.6'
             arch: x86
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.version }}

Project.toml

@@ -21,3 +21,6 @@ PrecompileTools = "1"
 TranscodingStreams = "0.9, 0.10, 0.11"
 Zlib_jll = "1"
 julia = "1.6.0"
+
+[workspace]
+projects = ["test"]

test/Project.toml

@@ -16,6 +16,4 @@ TranscodingStreams = "3bb67fe8-82b1-5028-8e26-92a6c54297fa"
 ZipArchives = "49080126-0e18-4c2a-b176-c102e4b3760c"
 ZipFile = "a5390f91-8eb1-5f08-bee0-b1d1ffed6cea"
 p7zip_jll = "3f19e933-33d8-53b3-aaab-bd5110c3b7a0"
-
-[sources]
-ZipArchives = {path = ".."}
+unzip_jll = "88f77b66-78eb-5ed0-bc16-ebba0796830d"

test/external_unzippers.jl

@@ -3,6 +3,7 @@
 # These functions take a zipfile path and a directory path and extract the zipfile into the directory
 import p7zip_jll
 import LibArchive_jll
+import unzip_jll
 # ENV["JULIA_CONDAPKG_BACKEND"] = "Null"
 try
     import PythonCall
@@ -33,6 +34,25 @@ function unzip_bsdtar(zippath, dirpath)
     nothing
 end
 
+function have_unzip_jll()
+    # unzip_jll is especially broken on windows.
+    # https://github.com/JuliaPackaging/Yggdrasil/issues/7679
+    !Sys.iswindows()
+end
+
+"""
+Extract the zip file at zippath into the directory dirpath
+Use unzip from unzip_jll
+"""
+function unzip_unzip_jll(zippath, dirpath)
+    try
+        run(`$(unzip_jll.unzip()) -qq $(zippath) -d $(dirpath)`)
+    catch
+        # unzip errors if the zip file is empty for some reason
+    end
+    nothing
+end
+
 function have_python()
     isdefined(@__MODULE__, :PythonCall)
 end
@@ -81,6 +101,12 @@ unzippers = Any[
     unzip_bsdtar,
 ]
 
+if have_unzip_jll()
+    push!(unzippers, unzip_unzip_jll)
+else
+    @info "unzip_jll is broken on this platform, skipping `unzip_unzip_jll` tests"
+end
+
 if have_python()
     push!(unzippers, unzip_python)
 else