Make matmul work with zero-less eltypes #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
requested review from
araujoms and
jishnub
and removed request for
jishnub
jishnub
reviewed
Nov 24, 2025
jishnub
approved these changes
Nov 24, 2025
jishnub
reviewed
Nov 24, 2025
jishnub
reviewed
Nov 24, 2025
Collaborator
|
I'm confused. I thought you wanted multiplication of empty matrices to fail, but it is just return a zero matrix of the appropriate size? |
Member
Author
|
No, I didn't want it to fail. And it has been working at least since v1.0. The only issue is that for empty matrices and a return eltype that doesn't have a |
araujoms
reviewed
Nov 24, 2025
araujoms
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows generic matmul to work with types that don't have a defined
zero, but for whichzerois defined on values. This avoids some trivial multiplications, and therefore contains a speed-up in generic syrk. I'm not sure if I was seeing slight performance drops in very small matrix cases, but AFAICT these code branches are not affected by the changes.Fixes #1486.