Skip to content

Commit af9befa

Browse files
authored
update tests, increment version for tagging (#17)
Updated tests, removed tee logger tests for Julia 1.8 onwards. Julia pipelining internals have changed in ways that make the current implementation break. Also with better tee logging support via other means, planning to drop this feature in the next version.
1 parent aa1b87c commit af9befa

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ uuid = "c41e01d8-14e5-11ea-185b-e7eabed7be4b"
33
keywords = ["log", "rotate", "roller", "logrotate"]
44
license = "MIT"
55
authors = ["Tanmay Mohapatra <[email protected]>"]
6-
version = "0.4.3"
6+
version = "0.4.4"
77

88
[compat]
99
julia = "1.2"

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ Constructor parameters in addition to those for `RollingFileWriter`:
4343
- `logger`: instance of AbstractLogger to tee log entries to
4444
- `assumed_level`: level of the log messages to assume (default Info)
4545

46+
Note: `RollingFileWriterTee` is supported only until Julia 1.7.
4647

4748
## `RollingLogger`
4849

test/runtests.jl

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,12 @@ function test_process_streams()
192192
@test isfile(rolledfile(filepath, 1))
193193
@test !isfile(rolledfile(filepath, 2))
194194

195-
@test io.procstream !== nothing
196-
@test io.procstreamer !== nothing
197-
@test !istaskdone(io.procstreamer)
195+
if VERSION < v"1.8"
196+
# pipelined processes are handled differently in Julia 1.8 and later
197+
@test io.procstream !== nothing
198+
@test io.procstreamer !== nothing
199+
@test !istaskdone(io.procstreamer)
200+
end
198201

199202
close(io)
200203
@test io.procstream === nothing
@@ -475,9 +478,14 @@ end
475478
@testset "file writer" begin
476479
test_filewriter()
477480
end
478-
@testset "pipelined tee" begin
479-
test_pipelined_tee()
481+
482+
if VERSION < v"1.8"
483+
# pipelined tee logger is available only on Julia 1.7 and earlier
484+
@testset "pipelined tee" begin
485+
test_pipelined_tee()
486+
end
480487
end
488+
481489
@testset "process streams" begin
482490
test_process_streams()
483491
end

0 commit comments

Comments
 (0)