fix #68: check logging method even though they has no parameter

Author: KengoTODA

CHANGELOG.md

@@ -6,6 +6,7 @@ This changelog follows [Keep a Changelog v1.0.0](https://keepachangelog.com/en/1
 ### Fixed
 
 - False negative around logging method with `Marker` instances ([#105](https://github.com/KengoTODA/findbugs-slf4j/pull/105))
+- False negative around logging method without parameter ([#68](https://github.com/KengoTODA/findbugs-slf4j/pull/68))
 
 ## 1.4.1 - 2018-06-17
 ### Changed

bug-pattern/src/main/java/jp/skypencil/findbugs/slf4j/parameter/AbstractDetectorForParameterArray.java

@@ -38,13 +38,6 @@ public abstract class AbstractDetectorForParameterArray extends OpcodeStackDetec
   private static final ImmutableSet<String> TARGET_METHOD_NAMES =
       ImmutableSet.of("trace", "debug", "info", "warn", "error");
 
-  @StaticConstant
-  // these methods do not use formatter
-  private static final ImmutableSet<String> SIGS_WITHOUT_FORMAT =
-      ImmutableSet.of(
-          "(Ljava/lang/String;)V",
-          "(Ljava/lang/String;Ljava/lang/Throwable;)V");
-
   @StaticConstant
   private static final Pattern SIGNATURE_PATTERN = Pattern.compile("^\\((.*)\\).*$");
 
@@ -187,9 +180,6 @@ private String findFormatString(String signature) {
       }
     }
 
-    if (SIGS_WITHOUT_FORMAT.contains(signature)) {
-      return null;
-    }
     return constant.toString();
   }
 

test-case/src/main/java/pkg/WithLombok.java

@@ -4,6 +4,6 @@
 
 public @Slf4j class WithLombok {
   void method(String name) {
-    log.info("Hello, {}");
+    log.info("Hello, {}.", "world");
   }
 }