From 44f12ddb25d62d5c2341331f9c28ce8ab06ea038 Mon Sep 17 00:00:00 2001 From: gserena Date: Fri, 5 Dec 2025 10:20:29 -0600 Subject: [PATCH 1/3] add show seams param to extrude --- modeling-cmds/src/def_enum.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modeling-cmds/src/def_enum.rs b/modeling-cmds/src/def_enum.rs index ce04621b..805c58e6 100644 --- a/modeling-cmds/src/def_enum.rs +++ b/modeling-cmds/src/def_enum.rs @@ -128,6 +128,11 @@ define_modeling_cmd_enum! { /// Should the extrusion create a new object or be part of the existing object. #[serde(default)] pub extrude_method: ExtrudeMethod, + /// Only used if the extrusion is created from a face and extrude_method = Merge + /// If true, seams between the extrusion and the original body will be shown. + /// Otherwise, seams resulting from the extrusion will be removed where possible. + #[serde(default)] + pub show_seams: Option, } /// Command for extruding a solid 2d to a reference geometry. From 88efaeaf76216b22092dec40c0ad55d674d75311 Mon Sep 17 00:00:00 2001 From: gserena Date: Wed, 10 Dec 2025 12:14:23 -0600 Subject: [PATCH 2/3] add showseams to tests --- modeling-session/examples/cube_png.rs | 1 + modeling-session/examples/cube_png_batch.rs | 1 + modeling-session/examples/lsystem_png_batch.rs | 1 + 3 files changed, 3 insertions(+) diff --git a/modeling-session/examples/cube_png.rs b/modeling-session/examples/cube_png.rs index ee77301e..899e34f2 100644 --- a/modeling-session/examples/cube_png.rs +++ b/modeling-session/examples/cube_png.rs @@ -113,6 +113,7 @@ async fn main() -> Result<()> { faces: None, opposite: Default::default(), extrude_method: Default::default(), + show_seams: Default::default(), } .into(), ) diff --git a/modeling-session/examples/cube_png_batch.rs b/modeling-session/examples/cube_png_batch.rs index dfa77936..1f5d1417 100644 --- a/modeling-session/examples/cube_png_batch.rs +++ b/modeling-session/examples/cube_png_batch.rs @@ -104,6 +104,7 @@ async fn main() -> Result<()> { faces: None, opposite: Default::default(), extrude_method: Default::default(), + show_seams: Default::default(), }), cmd_id: random_id(), }); diff --git a/modeling-session/examples/lsystem_png_batch.rs b/modeling-session/examples/lsystem_png_batch.rs index 2e9a30e1..4348e1e8 100644 --- a/modeling-session/examples/lsystem_png_batch.rs +++ b/modeling-session/examples/lsystem_png_batch.rs @@ -143,6 +143,7 @@ async fn main() -> Result<()> { faces: None, opposite: Default::default(), extrude_method: Default::default(), + show_seams: Default::default(), }), cmd_id: random_id(), }); From 05e2091d342e58866fb11e0c1a42d2cfaa7505ee Mon Sep 17 00:00:00 2001 From: gserena Date: Wed, 10 Dec 2025 13:45:27 -0600 Subject: [PATCH 3/3] rename --- modeling-cmds/src/def_enum.rs | 2 +- modeling-session/examples/cube_png.rs | 2 +- modeling-session/examples/cube_png_batch.rs | 2 +- modeling-session/examples/lsystem_png_batch.rs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modeling-cmds/src/def_enum.rs b/modeling-cmds/src/def_enum.rs index f1fb7384..8330e04b 100644 --- a/modeling-cmds/src/def_enum.rs +++ b/modeling-cmds/src/def_enum.rs @@ -133,7 +133,7 @@ define_modeling_cmd_enum! { /// If true, seams between the extrusion and the original body will be shown. /// Otherwise, seams resulting from the extrusion will be removed where possible. #[serde(default)] - pub show_seams: Option, + pub merge_coplanar_faces: Option, /// Should this extrude create a solid body or a surface? #[serde(default)] pub body_type: BodyType, diff --git a/modeling-session/examples/cube_png.rs b/modeling-session/examples/cube_png.rs index cd5e91a6..909d3c0b 100644 --- a/modeling-session/examples/cube_png.rs +++ b/modeling-session/examples/cube_png.rs @@ -113,7 +113,7 @@ async fn main() -> Result<()> { faces: None, opposite: Default::default(), extrude_method: Default::default(), - show_seams: Default::default(), + merge_coplanar_faces: Default::default(), body_type: Default::default(), } .into(), diff --git a/modeling-session/examples/cube_png_batch.rs b/modeling-session/examples/cube_png_batch.rs index 0f1237c3..088ae075 100644 --- a/modeling-session/examples/cube_png_batch.rs +++ b/modeling-session/examples/cube_png_batch.rs @@ -104,7 +104,7 @@ async fn main() -> Result<()> { faces: None, opposite: Default::default(), extrude_method: Default::default(), - show_seams: Default::default(), + merge_coplanar_faces: Default::default(), body_type: Default::default(), }), cmd_id: random_id(), diff --git a/modeling-session/examples/lsystem_png_batch.rs b/modeling-session/examples/lsystem_png_batch.rs index 4f9ba4b3..0389469f 100644 --- a/modeling-session/examples/lsystem_png_batch.rs +++ b/modeling-session/examples/lsystem_png_batch.rs @@ -143,7 +143,7 @@ async fn main() -> Result<()> { faces: None, opposite: Default::default(), extrude_method: Default::default(), - show_seams: Default::default(), + merge_coplanar_faces: Default::default(), body_type: Default::default(), }), cmd_id: random_id(),