-
Notifications
You must be signed in to change notification settings - Fork 10
add Unixlistener #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add Unixlistener #57
Conversation
|
i am not sure if i want to delete random files at start. It would be probably be better to just delete the socket at the drop implementation. |
|
No, you should not delete the socket file if it exists. Some daemon orchestrators like systemd will actually create the socket themselves and expect you to use that socket. I believe they also have a mode where they listen on the socket, and if a request comes in, starts the service on demand. But I have never used that feature of systemd, so I wouldn't know for sure, but I believe I read that systemd sets an environment variable so you'd know to re-use that socket, but then again I am against systemd-specific solutions, so I think we should just re-use the existing socket whenever we can. Also, it should be possible to set user/group/permissions on the unix socket file. Especially when the socket was not created by systemd, this comes in handy. But this can be done in a follow-up PR. |
Simplified the test job to run only on Ubuntu.
replace: #51
fix: #49
Change config:
move
portandlistento a single newlistener.If
listenerstart with with the prefixunix://, the listener will be interpreted as unix listener.