[test] Simplify test

Author: lpinca

test/shopify.test.js

@@ -917,81 +917,6 @@ describe('Shopify', () => {
       );
     });
 
-    it('can add a hook to not throw an error when the response has errors', () => {
-      const customerDataErrors = [
-        {
-          message:
-            'This app is not approved to use the email field. See https://partners.shopify.com/1/apps/1/customer_data for more details.',
-          path: ['customers', 'edges', '0', 'node', 'email'],
-          extensions: {
-            code: 'ACCESS_DENIED',
-            documentation:
-              'https://partners.shopify.com/1/apps/1/customer_data',
-            requiredAccess:
-              'Shopify approval is required before using the email field.'
-          }
-        },
-        {
-          message:
-            'This app is not approved to use the firstName field. See https://partners.shopify.com/1/apps/1/customer_data for more details.',
-          path: ['customers', 'edges', '0', 'node', 'firstName'],
-          extensions: {
-            code: 'ACCESS_DENIED',
-            documentation:
-              'https://partners.shopify.com/1/apps/1/customer_data',
-            requiredAccess:
-              'Shopify approval is required before using the firstName field.'
-          }
-        }
-      ];
-
-      let calledWithErrors = undefined;
-
-      const shopify = new Shopify({
-        shopName,
-        accessToken,
-        hooks: {
-          afterResponse: [
-            (res) => {
-              if (res.body && res.body.errors) {
-                calledWithErrors = res.body.errors;
-
-                res.body.errors = undefined;
-              }
-
-              return res;
-            }
-          ]
-        }
-      });
-
-      scope.post('/admin/api/graphql.json').reply(200, {
-        data: {
-          customers: {
-            edges: [
-              {
-                node: {
-                  id: 'gid://shopify/Customer/1234567890',
-                  email: null,
-                  firstName: null
-                }
-              }
-            ]
-          }
-        },
-        errors: customerDataErrors
-      });
-
-      return shopify.graphql('query').then((result) => {
-        expect(calledWithErrors).to.deep.equal(customerDataErrors);
-        expect(result.customers.edges[0].node.id).to.equal(
-          'gid://shopify/Customer/1234567890'
-        );
-        expect(result.customers.edges[0].node.email).to.equal(null);
-        expect(result.customers.edges[0].node.firstName).to.equal(null);
-      });
-    });
-
     it('uses basic auth as intended', () => {
       const shopify = new Shopify({ shopName, apiKey, password });
 
@@ -1313,6 +1238,62 @@ describe('Shopify', () => {
       });
     });
 
+    it('runs the afterResponse error hook after the user hooks', () => {
+      function afterResponse(response) {
+        afterResponse.errors = response.body.errors;
+        //
+        // Prevents errors from being thrown.
+        //
+        response.body.errors = undefined;
+        return response;
+      }
+
+      const data = {
+        customers: {
+          edges: [
+            {
+              node: {
+                id: 'gid://shopify/Customer/1234567890',
+                email: null
+              }
+            }
+          ]
+        }
+      };
+
+      const errors = [
+        {
+          message:
+            'This app is not approved to use the email field. ' +
+            'See https://partners.shopify.com/1/apps/1/customer_data ' +
+            'for more details.',
+          path: ['customers', 'edges', '0', 'node', 'email'],
+          extensions: {
+            code: 'ACCESS_DENIED',
+            documentation:
+              'https://partners.shopify.com/1/apps/1/customer_data',
+            requiredAccess:
+              'Shopify approval is required before using the email field.'
+          }
+        }
+      ];
+
+      scope.post('/admin/api/graphql.json').reply(200, { data, errors });
+
+      const shopify = new Shopify({
+        shopName,
+        accessToken,
+        hooks: {
+          afterResponse: [afterResponse]
+        }
+      });
+
+      return shopify.graphql('query').then((result) => {
+        expect(afterResponse.errors).to.deep.equal(errors);
+        expect(result).to.deep.equal(data);
+      });
+    });
+
     it('calls the beforeRetry hook for retried requests', () => {
       function beforeRetry() {
         beforeRetry.called = true;