MDEV-38003: Intermittent Replication Failure on a multi-table DELETE #4423
+107
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting from multiple tables, the DELETE operator uses a temporary table to collect the row IDs of rows that will be deleted. If this table grows too large, then we convert it from a heap temporary table to a persistent (on-disk) temporary table to avoid unbounded memory usage. There are several error codes that gate creating this persistent temporary table but themselves don't indicate a problem with the DELETE operation. However, regardless of this error code value, we need to clear it after deciding whether or not to create the persistent temporary table. If we don't clear this value, then the error code's stale state prevents binlog replication when its value is muxed with local_error during multi_delete::send_eof.
Member
Author
|
I tested multi-table UPDATE and it is not affected by this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting from multiple tables, the DELETE operator uses a temporary table to collect the row IDs of rows that will be deleted. If this table grows too large, then we convert it from a heap temporary table to a persistent (on-disk) temporary table to avoid unbounded memory usage. There are several error codes that gate creating this persistent temporary table but themselves don't indicate a problem with the DELETE operation. However, regardless of this error code value, we need to clear it after deciding whether or not to create the persistent temporary table. If we don't clear this value, then the error code's stale state prevents binlog replication when its value is muxed with local_error during multi_delete::send_eof.