Skip to content

Commit 12487f7

Browse files
chore: copy updates to messages.json (#37810)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? Made small copy tweaks around case consistency and grammar. 2. What is the improvement/solution? Minor language changes --> Various content updates based on our [content guidelines](https://www.notion.so/metamask-consensys/MetaMask-Content-Design-Style-Guide-7d0b7579786540afbe02780ebb203254?source=copy_link) [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37810?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: N/A ## **Related issues** Fixes: N/A ## **Manual testing steps** Only made copy updates. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> NA ### **After** <!-- [screenshots/recordings] --> NA ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refines grammar/punctuation in en/en_GB locale strings and updates related tests/snapshots to match. > > - **i18n (copy tweaks)** > - Standardize phrasing and punctuation in `app/_locales/en/messages.json` and `app/_locales/en_GB/messages.json` (e.g., `All-time high/low`, remove trailing punctuation in some labels, lowercase "Price impact" tooltip title, add period to smart account switch description, capitalize URL in NFT disclaimer, remove exclamation in install complete, normalize "Learn more"). > - **Tests** > - Adjust e2e expectation for smart account upgrade text in `account-modal-account-type-change.spec.ts`. > - Update confirmation title test to expect period in smart account switch description. > - Refresh snapshots for NFT details disclaimer and onboarding create-password link text. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 477c5ac. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: georgewrmarshall <[email protected]>
1 parent 1f1bf43 commit 12487f7

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed

app/_locales/en/messages.json

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/en_GB/messages.json

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/tests/account/account-modal-account-type-change.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe.skip('Switch Modal - Switch Account', function (this: Suite) {
4545

4646
const upgradeAndBatchTxConfirmation = new Eip7702AndSendCalls(driver);
4747
await upgradeAndBatchTxConfirmation.checkExpectedTxTypeIsDisplayed(
48-
"You're switching to a smart account",
48+
"You're switching to a smart account.",
4949
);
5050
await upgradeAndBatchTxConfirmation.checkExpectedInteractingWithIsDisplayed(
5151
'Account 1',

ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ exports[`NFT Details should match minimal props and state snapshot 1`] = `
181181
<p
182182
class="mm-box mm-text mm-text--body-xs mm-box--color-text-alternative"
183183
>
184-
Disclaimer: MetaMask pulls the media file from the source url. This url sometimes gets changed by the marketplace on which the NFT was minted.
184+
Disclaimer: MetaMask pulls the media file from the source URL. This URL sometimes gets changed by the marketplace on which the NFT was minted.
185185
</p>
186186
</div>
187187
</div>

ui/pages/confirmations/components/confirm/title/title.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ describe('ConfirmTitle', () => {
110110

111111
expect(getByText('Account update')).toBeInTheDocument();
112112
expect(
113-
getByText("You're switching to a smart account"),
113+
getByText("You're switching to a smart account."),
114114
).toBeInTheDocument();
115115
});
116116

ui/pages/onboarding-flow/create-password/__snapshots__/create-password.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ exports[`Onboarding Create Password Render should match snapshot 1`] = `
146146
<span
147147
class="create-password__link-text"
148148
>
149-
Learn more.
149+
Learn more
150150
</span>
151151
</a>
152152
</p>

0 commit comments

Comments
 (0)