feat(SDKConnectV2): add toasts for non-success states (#22610)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR adds to the current implementation of MetaMask Connect toasts to
ensure that error messages are displayed in the Wallet when a user
rejects a request or when other errors occur during the request
lifecycle.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-825

## **Manual testing steps**

```gherkin
Feature: MM Connect toasts for non-success states

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


https://github.com/user-attachments/assets/e977ff69-aedd-4136-99a9-9e9e90f5e663

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Show an error toast when bridge responses contain JSON-RPC errors and
use the connection id for error notifications; add tests for
success/error paths.
> 
> - **SDKConnectV2**:
> - **Connection (`services/connection.ts`)**: On bridge `response`,
detect JSON-RPC errors (`error` in payload) and call
`hostApp.showConnectionError(this.info)`; otherwise call
`showReturnToApp(this.info)`. Always forward payload to client.
> - **Host App Adapter (`adapters/host-application-adapter.ts`)**:
Change `showConnectionError` signature to `conninfo?` and use
`conninfo.id` when provided (fallback to timestamp).
> - **Types (`types/host-application-adapter.ts`)**: Update interface
for `showConnectionError(conninfo?)` and clarify return-to-app success
doc.
> - **Tests**:
> - Add/update cases validating error vs success toasts and that error
notifications use the connection id; ensure responses without `id` don’t
trigger return-to-app.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
803a6b5. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: ffmcgee725

app/core/SDKConnectV2/adapters/host-application-adapter.test.ts

@@ -118,6 +118,22 @@ describe('HostApplicationAdapter', () => {
       });
       expect(store.dispatch).toHaveBeenCalledTimes(1);
     });
+
+    it('dispatches an error notification when request is rejected or fails', () => {
+      adapter.showConnectionError(
+        createMockConnectionInfo('session-123', 'Test DApp'),
+      );
+
+      expect(showSimpleNotification).toHaveBeenCalledTimes(1);
+      expect(showSimpleNotification).toHaveBeenCalledWith({
+        id: 'session-123',
+        autodismiss: 5000,
+        title: 'sdk_connect_v2.show_error.title',
+        description: 'sdk_connect_v2.show_error.description',
+        status: 'error',
+      });
+      expect(store.dispatch).toHaveBeenCalledTimes(1);
+    });
   });
 
   describe('showReturnToApp', () => {

app/core/SDKConnectV2/adapters/host-application-adapter.ts

@@ -33,10 +33,10 @@ export class HostApplicationAdapter implements IHostApplicationAdapter {
     store.dispatch(hideNotificationById(conninfo.id));
   }
 
-  showConnectionError(): void {
+  showConnectionError(conninfo?: ConnectionInfo): void {
     store.dispatch(
       showSimpleNotification({
-        id: Date.now().toString(),
+        id: conninfo?.id || Date.now().toString(),
         autodismiss: 5000,
         title: strings('sdk_connect_v2.show_error.title'),
         description: strings('sdk_connect_v2.show_error.description'),

app/core/SDKConnectV2/services/connection.test.ts

@@ -331,5 +331,74 @@ describe('Connection', () => {
         responsePayload,
       );
     });
+
+    it('shows error toast when bridge response includes an error', async () => {
+      await Connection.create(
+        mockConnectionInfo,
+        mockKeyManager,
+        RELAY_URL,
+        mockHostApp,
+      );
+
+      const errorResponsePayload = {
+        data: {
+          id: 1,
+          jsonrpc: '2.0',
+          error: {
+            code: -32000,
+            message: 'User rejected the request',
+          },
+        },
+      };
+
+      // Simulate the RPCBridgeAdapter emitting an error response
+      onBridgeResponseCallback(errorResponsePayload);
+
+      // Should show error toast, not success toast
+      expect(mockHostApp.showConnectionError).toHaveBeenCalledTimes(1);
+      expect(mockHostApp.showConnectionError).toHaveBeenCalledWith(
+        mockConnectionInfo,
+      );
+      expect(mockHostApp.showReturnToApp).not.toHaveBeenCalled();
+
+      // And still send the error response to the client
+      expect(mockWalletClientInstance.sendResponse).toHaveBeenCalledTimes(1);
+      expect(mockWalletClientInstance.sendResponse).toHaveBeenCalledWith(
+        errorResponsePayload,
+      );
+    });
+
+    it('shows success toast for successful response with result', async () => {
+      await Connection.create(
+        mockConnectionInfo,
+        mockKeyManager,
+        RELAY_URL,
+        mockHostApp,
+      );
+
+      const successResponsePayload = {
+        data: {
+          id: 1,
+          jsonrpc: '2.0',
+          result: ['0x123'],
+        },
+      };
+
+      // Simulate the RPCBridgeAdapter emitting a success response
+      onBridgeResponseCallback(successResponsePayload);
+
+      // Should show success toast, not error toast
+      expect(mockHostApp.showReturnToApp).toHaveBeenCalledTimes(1);
+      expect(mockHostApp.showReturnToApp).toHaveBeenCalledWith(
+        mockConnectionInfo,
+      );
+      expect(mockHostApp.showConnectionError).not.toHaveBeenCalled();
+
+      // And still send the response to the client
+      expect(mockWalletClientInstance.sendResponse).toHaveBeenCalledTimes(1);
+      expect(mockWalletClientInstance.sendResponse).toHaveBeenCalledWith(
+        successResponsePayload,
+      );
+    });
   });
 });

app/core/SDKConnectV2/services/connection.ts

@@ -46,7 +46,16 @@ export class Connection {
 
       // If the payload includes an id, its a JSON-RPC response, otherwise its a notification
       if ('data' in payload && 'id' in payload.data) {
-        this.hostApp.showReturnToApp(this.info);
+        const responseData = payload.data;
+        // Check if the response is an error (JSON-RPC error responses have an 'error' property)
+        const isError =
+          'error' in responseData && responseData.error !== undefined;
+
+        if (isError) {
+          this.hostApp.showConnectionError(this.info);
+        } else {
+          this.hostApp.showReturnToApp(this.info);
+        }
       }
 
       this.client.sendResponse(payload);

app/core/SDKConnectV2/types/host-application-adapter.ts

@@ -23,10 +23,10 @@ export interface IHostApplicationAdapter {
   /**
    * Displays a global, non-interactive error modal.
    */
-  showConnectionError(): void;
+  showConnectionError(conninfo?: ConnectionInfo): void;
 
   /**
-   * Displays a "Return to App" toast notification.
+   * Displays a "Return to App" toast notification for successful requests.
    */
   showReturnToApp(conninfo: ConnectionInfo): void;