Skip to content

Conversation

@PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Nov 13, 2025

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Inline network details in NetworkVerificationInfo, simplify styles/layout, and update tests/snapshots accordingly.

  • UI (NetworkVerificationInfo):
    • Remove Accordion; always render details inline: Chain ID, Display name, and Block explorer URL.
    • Simplify layout: add flex: 1 to accountCardWrapper, set contentContainerStyle with paddingBottom: 24, and remove onLayout/max-height logic.
    • Keep RPC URL row with optional "Review" tag; show URL with hideKeyFromUrl.
  • Styles:
    • Update NetworkVerificationInfo.styles.ts: add flex: 1 to accountCardWrapper; define nestedScrollContent with bottom padding.
  • Tests/Snapshots:
    • Update snapshots in NetworkVerificationInfo and NetworkModal to reflect inline details and style changes.
    • Remove accordion interaction in tests; adjust test name to "renders chainId as a decimal" and expectations.
  • Cleanup:
    • Remove unused state/imports related to accordion and layout measurement.

Written by Cursor Bugbot for commit e6b74c0. This will update automatically on new commits. Configure here.

@PatrykLucka PatrykLucka self-assigned this Nov 13, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Nov 13, 2025
@sonarqubecloud
Copy link

@PatrykLucka PatrykLucka marked this pull request as ready for review November 13, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants