xenna_grafana_dashboard.json missing from the wheel — Xenna Grafana dashboard is never provisioned

[mgrbyte]

Summary

nemo_curator/metrics/xenna_grafana_dashboard.json exists in the git tree but is not included in the published wheel, so launch_grafana's dashboard copy silently skips and wheel users never get the Xenna dashboard in Grafana.

Reproduction (nemo-curator 1.2.0)

$ pip install nemo-curator
$ ls .venv/lib/python3.12/site-packages/nemo_curator/metrics/
__init__.py  constants.py  start_prometheus_grafana.py  utils.py

The json (and the module README) are absent. In nemo_curator/metrics/utils.py the copy is guarded:

xenna_dashboard_src = os.path.join(os.path.dirname(__file__), "xenna_grafana_dashboard.json")
...
if os.path.isfile(xenna_dashboard_src) and not os.path.isfile(xenna_dashboard_dst):
    shutil.copy(xenna_dashboard_src, xenna_dashboard_dst)

so the missing file skips silently: start_prometheus_grafana provisions the four auto-generated Ray dashboards but never the Xenna one.

Expected

The Xenna dashboard json ships in the wheel (package data), so monitoring set up per the metrics README includes the Xenna dashboard.

Suggested fix

Include nemo_curator/metrics/*.json as package data in the build configuration; optionally log a warning instead of skipping silently when the source json is missing.

[nightcityblade]

Hi, I'd like to work on this. I'll submit a PR shortly.

[nightcityblade]

I reproduced the wheel build from current main before changing anything. The resulting wheel already contains both nemo_curator/metrics/xenna_grafana_dashboard.json and nemo_curator/metrics/README.md, so this appears fixed since the 1.2.0 release. I'm stepping back and unclaiming rather than submitting a redundant change.

[mgrbyte]

I can see from the released v1.2.0 areifact that xenna_grafana_dashboard.json exists in the both the .whl,.zip, .tar.gz files.
However, upon installing into a venv (using uv) the following find command shows that it it absent in the virtual end upon installation:
find .venv/lib/python3.12/site-packages/nemo_curator -type f -name '*.json' # no results

I currently have the following dependencies entries in my project.toml file:

    "nemo-curator[text-cuda12]>=1.2.0; sys_platform == 'linux'",
    "nemo-curator[text-cpu]>=1.2.0; sys_platform == 'darwin'",

I have tested an install on both linux and macos platforms, and the same missing file condition holds on both.

[nightcityblade]

Thanks for the clarification. I’ll reproduce the installed-wheel behavior and submit a focused package-data fix with a regression check shortly.

[nightcityblade]

I reproduced this again from current main with uv build --wheel, then installed that wheel into a fresh Python 3.12 environment using uv pip install --no-deps. Both nemo_curator/metrics/xenna_grafana_dashboard.json and nemo_curator/metrics/README.md are present in the installed package. Since current main already behaves as expected, I am unclaiming rather than submitting a redundant configuration change.