Skip to content

Commit 99566ad

Browse files
committed
fix(ci): keep cuobjdump deselect environment-gated
1 parent f687d34 commit 99566ad

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

‎.github/workflows/test-wheel-linux.yml‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -487,11 +487,21 @@ jobs:
487487
# numba package at collection time, which cuSIMT intentionally does
488488
# not depend on. See NVIDIA/numba-cuda-mlir#136.
489489
#
490+
DESELECTS=()
491+
# Environment-gated deselect: cuobjdump is not on PATH in the base
492+
# ubuntu:24.04 container. Keep this independent of the version gate
493+
# below so an unrelated upstream fix cannot retire it. See
494+
# NVIDIA/numba-cuda-mlir#286.
495+
if ! command -v cuobjdump > /dev/null; then
496+
DESELECTS+=(
497+
--deselect 'tests/numba_cuda_tests/cudadrv/test_nvjitlink.py::TestLinkerDumpAssembly::test_nvjitlink_jit_with_linkable_code_lto_dump_assembly_warn'
498+
)
499+
fi
500+
490501
# Version-gated deselects: when a newer numba-cuda-mlir release
491502
# ships with the referenced fix, the guard evaluates false and the
492503
# tests get run automatically. If they still fail on the newer
493504
# version we hear about it loudly (rather than silently masking).
494-
DESELECTS=()
495505
if python -c "from packaging.version import Version; import sys; sys.exit(0 if Version('${NUMBA_CUDA_MLIR_VER}') <= Version('0.4.1') else 1)"; then
496506
# NVIDIA/numba-cuda-mlir#135: serial-pytest contamination of
497507
# numba_cuda_mlir.cuda.cudadrv from an xfailed test in
@@ -502,12 +512,6 @@ jobs:
502512
# win-64 across runs), so we deselect the union of all tests
503513
# #135 lists as vulnerable + test_fortran_contiguous (observed
504514
# to hit the same contamination in our runs).
505-
#
506-
# test_nvjitlink_jit_with_linkable_code_lto_dump_assembly_warn:
507-
# subprocess-invokes `cuobjdump`, not on PATH in the base
508-
# ubuntu:24.04 container. (Linux-only; Windows runners ship
509-
# cuobjdump with the local CTK. No upstream fix yet — pending
510-
# a skip-guard bug to be filed against NVIDIA/numba-cuda-mlir.)
511515
DESELECTS+=(
512516
--deselect 'tests/numba_cuda_tests/cudadrv/test_cuda_array_slicing.py::CudaArraySetting::test_no_sync_default_stream'
513517
--deselect 'tests/numba_cuda_tests/cudadrv/test_cuda_array_slicing.py::CudaArraySetting::test_no_sync_supplied_stream'
@@ -518,7 +522,6 @@ jobs:
518522
--deselect 'tests/numba_cuda_tests/cudapy/test_cuda_array_interface.py::TestCudaArrayInterface::test_launch_sync'
519523
--deselect 'tests/numba_cuda_tests/cudapy/test_cuda_array_interface.py::TestCudaArrayInterface::test_launch_sync_two_streams'
520524
--deselect 'tests/numba_cuda_tests/cudapy/test_cuda_array_interface.py::TestCudaArrayInterface::test_fortran_contiguous'
521-
--deselect 'tests/numba_cuda_tests/cudadrv/test_nvjitlink.py::TestLinkerDumpAssembly::test_nvjitlink_jit_with_linkable_code_lto_dump_assembly_warn'
522525
)
523526
fi
524527
pytest -rxXs -v \

0 commit comments

Comments
 (0)