fix: remove keys from package.json after project is created

Remove confusing keys from project's package.json when Template v2 is used. Remove `name` and `version` as the users may decide we will use the values to set project name and version of the application.

Author: rosen-vladimirov

lib/constants.ts

@@ -54,6 +54,7 @@ export class LiveSyncTrackActionNames {
 }
 
 export const PackageJsonKeysToKeep: Array<String> = ["name", "main", "android", "version", "pluginsData"];
+export const TemplatesV2PackageJsonKeysToRemove: Array<String> = ["name", "version", "displayName", "templateType", "author", "keywords", "homepage", "bugs"];
 
 export class SaveOptions {
 	static PRODUCTION = "save";

lib/services/project-service.ts

@@ -3,7 +3,7 @@ import * as path from "path";
 import * as shelljs from "shelljs";
 import { format } from "util";
 import { exported } from "../common/decorators";
-import { Hooks } from "../constants";
+import { Hooks, TemplatesV2PackageJsonKeysToRemove } from "../constants";
 
 export class ProjectService implements IProjectService {
 
@@ -212,7 +212,7 @@ export class ProjectService implements IProjectService {
 		const packageJsonData = this.$fs.readJson(projectFilePath);
 
 		// Remove the metadata keys from the package.json
-		let updatedPackageJsonData = _.omitBy<any, any>(packageJsonData, (value: any, key: string) => _.startsWith(key, "_"));
+		let updatedPackageJsonData = _.omitBy<any, any>(packageJsonData, (value: any, key: string) => _.startsWith(key, "_") || TemplatesV2PackageJsonKeysToRemove.indexOf(key) !== -1);
 		updatedPackageJsonData = _.merge(updatedPackageJsonData, this.packageJsonDefaultData);
 
 		if (updatedPackageJsonData.nativescript && updatedPackageJsonData.nativescript.templateVersion) {