(feat): Make fitdefault option also for iOS. Bump version for breaking change

Author: Veselina Radeva

README.md

@@ -130,7 +130,7 @@ Once image is picked some options can be applied to it  before it is used:
 | --- | --- | --- |
 | maxWidth | null | Image max width |
 | maxHeight | null | Image max height |
-| iosAspectRatio | fill | iOS only. Possible values are `fit` and `fill`. [Read more](https://developer.apple.com/documentation/photos/phimagecontentmode) |
+| aspectRatio | fit | iOS only. Possible values are `fit` and `fill`. [Read more](https://developer.apple.com/documentation/photos/phimagecontentmode) |
 
 ## License
 

demo/app/main-page.ts

@@ -35,7 +35,7 @@ function startSelection(context, isSingle) {
                 console.log("----------------");
                 console.log("uri: " + selected.uri);
                 if(isSingle){
-                    selected.getImage({ maxWidth: 200, maxHeight: 200, iosAspectRatio: 'fit' })
+                    selected.getImage({ maxWidth: 200, maxHeight: 200, aspectRatio: 'fill' })
                     .then((imageSource) => {
                         imageSrc.src = imageSource;
                     });

src/imagepicker.ios.ts

@@ -19,7 +19,7 @@ const IMAGE_HEIGHT = 80;
 interface ImageOptions {
     maxWidth?: number;
     maxHeight?: number;
-    iosAspectRatio?: "fill" | "fit";
+    aspectRatio?: "fill" | "fit";
 }
 
 export function create(options?): ImagePicker {
@@ -345,7 +345,7 @@ class ImagePickerPH extends ImagePicker {
         return new Promise<image_source.ImageSource>((resolve, reject) => {
             let size: CGSize = options ? CGSizeMake(options.maxWidth, options.maxHeight) : PHImageManagerMaximumSize;
             let resizeMode = PHImageRequestOptions.alloc().init();
-            let aspectRatio = (options && options.iosAspectRatio && options.iosAspectRatio === 'fit') ? PHImageContentMode.AspectFit : PHImageContentMode.AspectFill;
+            let aspectRatio = (options && options.aspectRatio && options.aspectRatio === 'fill') ? PHImageContentMode.AspectFill : PHImageContentMode.AspectFit;
 
             // TODO: Decide whether it is benefical to use PHImageRequestOptionsResizeModeFast
             //       Accuracy vs Performance. It is probably best to expose these as iOS specific options.

src/index.d.ts

@@ -14,9 +14,9 @@ export interface ImageOptions {
     maxHeight?: number;
 
     /**
-     * iOS only. The image aspect ratio. Default value: fill.
+     * iOS only. The image aspect ratio. Default value: fit.
      */
-    iosAspectRatio?: "fill" | "fit";
+    aspectRatio?: "fill" | "fit";
 }
 
 export class SelectedAsset extends imageAssetModule.ImageAsset {

src/package.json

@@ -1,6 +1,6 @@
 {
     "name": "nativescript-imagepicker",
-    "version": "3.0.7",
+    "version": "4.0.0",
     "description": "A plugin for the NativeScript framework implementing multiple image picker",
     "repository": {
         "type": "git",