Skip to content

Commit da0402a

Browse files
author
radeva
authored
Merge pull request #164 from NativeScript/branch/replace-pro-ui
chore: migrate to split list-view package
2 parents f405298 + f23869f commit da0402a

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Imagepicker plugin supporting both single and multiple selection.
1313

1414
- [Installation](#installation)
1515
- [Configuration](#configuration)
16+
- [Migrating from 4.x.x to 5.x.x](#migrating-from-4xx-to-5xx)
1617
- [Migrating from 3.x.x to 4.x.x](#migrating-from-3xx-to-4xx)
1718
- [Usage](#usage)
1819
- [Import the plugin](#import-the-plugin)
@@ -34,11 +35,14 @@ In Command prompt / Terminal navigate to your application root folder and run:
3435

3536
```
3637
tns plugin add nativescript-imagepicker
37-
```
38+
```tns run
3839
3940
## Configuration
4041
No additional configuration required!
4142
43+
## Migrating from 4.x.x to 5.x.x
44+
With version **5.x.x** major update to the plugin there is a related dependency which needs to be updated inside your project. The plugin uses internally the `nativescript-ui-listview` plugin (part of the NativeScript Pro UI components). Recently the monolithic [NativeScript Pro UI plugin was split in multiple plugins](https://www.nativescript.org/blog/professional-components-from-nativescript-ui-the-big-breakup), each of them representing a single component. Now, instead of the monolithic package, nativescript-imagepicker uses only the component it needs. To use version 5.x.x of the plugin, you need to update any dependencies to `nativescript-pro-ui` in your project with the single component alternatives as described in the [migration guide](http://docs.telerik.com/devtools/nativescript-ui/migration).
45+
4246
## Migrating from 3.x.x to 4.x.x
4347
With the **4.x.x** major update to the plugin there is a related dependency which needs to be updated inside your project. The plugin uses internally the `nativescript-pro-ui` plugin (previously known as `nativescript-telerik-ui`) which has bee updated and made 100% free. This means that if your project is using the deprecated `nativescript-telerik-ui`/`pro` plugins adding the latest version of the `nativescript-imagepicker` plugin will cause your project to throw an build error when working with iOS. This is because the `nativescript-imagepicker` has a dependency to the new `nativescript-pro-ui` plugin and when your project also depends on the old `nativescript-telerik-ui` plugin there is a native frameworks collision.
4448

src/images.ios.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import platform = require("tns-core-modules/platform");
44
import ui_frame = require("tns-core-modules/ui/frame");
55
import { Page } from "tns-core-modules/ui/page";
66
import { ActionBar, NavigationButton, ActionItems, ActionItem } from "tns-core-modules/ui/action-bar";
7-
import { RadListView, ListViewGridLayout } from "nativescript-pro-ui/listview";
7+
import { RadListView, ListViewGridLayout } from "nativescript-ui-listview";
88

99
let page;
1010
let list;

src/images.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<Page xmlns="http://www.nativescript.org/tns.xsd" loaded="pageLoaded"
2-
xmlns:lv="nativescript-pro-ui/listview">
2+
xmlns:lv="nativescript-ui-listview">
33

44
<Page.actionBar>
55
<ActionBar title="{{ title }}">

src/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
},
1717
"scripts": {
1818
"ngc": "node --max-old-space-size=8192 ./node_modules/.bin/ngc",
19-
"build": "npm i && tsc",
19+
"build": "npm i && tsc",
2020
"prepublishOnly": "npm run build",
2121
"ci.tslint": "npm i && tslint '**/*.ts' --config '../tslint.json' --exclude '**/node_modules/**'",
2222
"tsc": "tsc -skipLibCheck",
@@ -52,7 +52,7 @@
5252
"tslint": "~5.4.3"
5353
},
5454
"dependencies": {
55-
"nativescript-pro-ui": "^3.1.2",
55+
"nativescript-ui-listview": "^3.5.0",
5656
"nativescript-permissions": "~1.2.3"
5757
},
5858
"bootstrapper": "nativescript-plugin-seed"

0 commit comments

Comments
 (0)