feat: refactor Errors, remove unnecessary lines

Seems like many things were unnecessary, probably pre-es6.

Author: kirillgroshkov

src/error/app.error.test.ts

@@ -1,3 +1,4 @@
+import { inspect } from 'util'
 import { AppError } from './app.error'
 
 const throwAppError = () => {
@@ -31,3 +32,24 @@ test('appError should work when Error.captureStacktrace is n/a', () => {
   expect(r.name).toBe('AppError')
   expect(r.stack).not.toBeUndefined()
 })
+
+test('AppError log should NOT include constructor and data', () => {
+  const err = new AppError('hello')
+  // console.log(err)
+
+  expect(err.name).toBe('AppError')
+  expect(err.constructor.name).toBe('AppError')
+  expect(err.constructor).toBe(AppError)
+  const s = filterStackTrace(inspect(err))
+  // console.log(s)
+
+  expect(s).not.toContain('constructor')
+  expect(s).not.toContain('data')
+})
+
+function filterStackTrace(s: string): string {
+  return s
+    .split('\n')
+    .filter(line => !line.trimStart().startsWith('at '))
+    .join('\n')
+}

src/error/app.error.ts

@@ -10,16 +10,22 @@ import { ErrorData } from './error.model'
  * Based on: https://medium.com/@xpl/javascript-deriving-from-error-properly-8d2f8f315801
  */
 export class AppError<DATA_TYPE extends ErrorData = ErrorData> extends Error {
-  constructor(message: string, public data = {} as DATA_TYPE) {
+  data!: DATA_TYPE
+
+  constructor(message: string, data = {} as DATA_TYPE) {
     super(message)
 
-    this.constructor = AppError
-    ;(this as any).__proto__ = AppError.prototype
     Object.defineProperty(this, 'name', {
       value: this.constructor.name,
       configurable: true,
     })
 
+    Object.defineProperty(this, 'data', {
+      value: data,
+      configurable: true,
+      enumerable: false,
+    })
+
     if (Error.captureStackTrace) {
       Error.captureStackTrace(this, this.constructor)
     } else {

src/error/assert.test.ts

@@ -1,3 +1,4 @@
+import { inspect } from 'util'
 import {
   AssertionError,
   _assert,
@@ -98,3 +99,26 @@ test('_assertIsNumber', () => {
     got     : string]
   `)
 })
+
+test('AssertionError printability', () => {
+  const err = new AssertionError('error', { userFriendly: true })
+  // console.log(err)
+
+  expect(err.name).toBe('AssertionError')
+  expect(err.constructor.name).toBe('AssertionError')
+  expect(err.constructor).toBe(AssertionError)
+  const s = filterStackTrace(inspect(err))
+  // console.log(s)
+
+  expect(s).not.toContain('constructor')
+  expect(s).not.toContain('data')
+
+  expect(err.data).toEqual({ userFriendly: true })
+})
+
+function filterStackTrace(s: string): string {
+  return s
+    .split('\n')
+    .filter(line => !line.trimStart().startsWith('at '))
+    .join('\n')
+}

src/error/assert.ts

@@ -123,23 +123,7 @@ export function _assertTypeOf<T>(v: any, expectedType: string, message?: string)
 }
 
 export class AssertionError extends AppError {
-  constructor(message: string, data: ErrorData) {
+  constructor(message: string, data = {} as ErrorData) {
     super(message, data)
-
-    this.constructor = AssertionError
-    ;(this as any).__proto__ = AssertionError.prototype
-    Object.defineProperty(this, 'name', {
-      value: this.constructor.name,
-      configurable: true, // otherwise throws with "TypeError: Cannot redefine property: name"
-    })
-
-    if (Error.captureStackTrace) {
-      Error.captureStackTrace(this, this.constructor)
-    } else {
-      Object.defineProperty(this, 'stack', {
-        value: new Error().stack, // eslint-disable-line unicorn/error-message
-        configurable: true,
-      })
-    }
   }
 }

src/error/http.error.test.ts

@@ -1,3 +1,4 @@
+import { inspect } from 'util'
 import { _errorToErrorObject } from '../index'
 import { HttpError } from './http.error'
 
@@ -18,3 +19,26 @@ test('default error to match snapshot', async () => {
   expect(throwHttpError).toThrow(HttpError)
   await expect(throwHttpErrorAsync()).rejects.toThrow(HttpError)
 })
+
+test('httpError printability', () => {
+  const err = new HttpError('error', { httpStatusCode: 500 })
+  // console.log(err)
+
+  expect(err.name).toBe('HttpError')
+  expect(err.constructor.name).toBe('HttpError')
+  expect(err.constructor).toBe(HttpError)
+  const s = filterStackTrace(inspect(err))
+  // console.log(s)
+
+  expect(s).not.toContain('constructor')
+  expect(s).not.toContain('data')
+
+  expect(err.data).toEqual({ httpStatusCode: 500 })
+})
+
+function filterStackTrace(s: string): string {
+  return s
+    .split('\n')
+    .filter(line => !line.trimStart().startsWith('at '))
+    .join('\n')
+}

src/error/http.error.ts

@@ -9,21 +9,5 @@ export class HttpError<
 > extends AppError<DATA_TYPE> {
   constructor(message: string, data: DATA_TYPE) {
     super(message, data)
-
-    this.constructor = HttpError
-    ;(this as any).__proto__ = HttpError.prototype
-    Object.defineProperty(this, 'name', {
-      value: this.constructor.name,
-      configurable: true, // otherwise throws with "TypeError: Cannot redefine property: name"
-    })
-
-    if (Error.captureStackTrace) {
-      Error.captureStackTrace(this, this.constructor)
-    } else {
-      Object.defineProperty(this, 'stack', {
-        value: new Error().stack, // eslint-disable-line unicorn/error-message
-        configurable: true,
-      })
-    }
   }
 }

src/promise/AggregatedError.ts

@@ -23,8 +23,6 @@ export class AggregatedError<RESULT = any> extends Error {
     this.errors = mappedErrors
     this.results = results
 
-    this.constructor = AggregatedError
-    ;(this as any).__proto__ = AggregatedError.prototype
     Object.defineProperty(this, 'name', {
       value: this.constructor.name,
       configurable: true,