fix(no-reset-all-state-on-prop-change): false negatives on custom hooks

Closes
#42

Author: NickvanDyke

src/no-reset-all-state-on-prop-change.js

@@ -35,6 +35,9 @@ export default {
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;
+      // Skip custom hooks because they can't receive `key` like components can.
+      const containingNode = findContainingNode(node);
+      if (containingNode && isCustomHook(containingNode)) return;
 
       const propUsedToResetAllState = findPropUsedToResetAllState(
         context,

test/no-reset-all-state-on-prop-change.test.js

@@ -60,6 +60,20 @@ new MyRuleTester().run("no-reset-all-state-on-prop-change", rule, {
         }
       `,
     },
+    {
+      name: "Reset all state when a prop changes in a custom hook",
+      code: js`
+        function useCustomHook({ userId }) {
+          const [user, setUser] = useState(null);
+          const [comment, setComment] = useState('type something');
+
+          useEffect(() => {
+            setUser(null);
+            setComment('type something');
+          }, [userId]);
+        }
+      `,
+    },
   ],
   invalid: [
     {