refactor: check isUseEffect explicitly in rules

more readable/obvious than doing when getting effect fn and deps

Author: NickvanDyke

src/no-adjust-state-on-prop-change.js

@@ -6,6 +6,7 @@ import {
   isImmediateCall,
   isProp,
   isStateSetter,
+  isUseEffect,
 } from "./util/react.js";
 
 /**
@@ -26,6 +27,7 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;

src/no-chain-state-updates.js

@@ -7,6 +7,7 @@ import {
   isImmediateCall,
   isState,
   isStateSetter,
+  isUseEffect,
 } from "./util/react.js";
 
 /**
@@ -27,10 +28,10 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node) || hasCleanup(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;
-      if (hasCleanup(node)) return;
 
       // TODO: Should filter out setters before checking?
       // exhaustive-deps doesn't enforce one way or the other.

src/no-derived-state.js

@@ -8,6 +8,7 @@ import {
   getUpstreamReactVariables,
   isState,
   hasCleanup,
+  isUseEffect,
 } from "./util/react.js";
 import { getCallExpr, getDownstreamRefs } from "./util/ast.js";
 
@@ -29,10 +30,10 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node) || hasCleanup(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;
-      if (hasCleanup(node)) return;
 
       effectFnRefs
         .filter((ref) => isStateSetter(context, ref))

src/no-event-handler.js

@@ -2,6 +2,7 @@ import {
   getEffectFnRefs,
   getEffectDepsRefs,
   hasCleanup,
+  isUseEffect,
 } from "./util/react.js";
 import { findDownstreamNodes, getDownstreamRefs } from "./util/ast.js";
 import { isState } from "./util/react.js";
@@ -24,10 +25,10 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node) || hasCleanup(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;
-      if (hasCleanup(node)) return;
 
       // TODO: Can we also flag this when the deps are internal, and the body calls internal stuff?
       // That'd overlap with other rules though... maybe just useRefs?

src/no-initialize-state.js

@@ -5,6 +5,7 @@ import {
   getUseStateNode,
   isImmediateCall,
   isStateSetter,
+  isUseEffect,
 } from "./util/react.js";
 
 /**
@@ -24,6 +25,7 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;

src/no-manage-parent.js

@@ -1,4 +1,8 @@
-import { getEffectFnRefs, getEffectDepsRefs } from "./util/react.js";
+import {
+  getEffectFnRefs,
+  getEffectDepsRefs,
+  isUseEffect,
+} from "./util/react.js";
 import { isProp } from "./util/react.js";
 
 /**
@@ -18,6 +22,7 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;

src/no-pass-data-to-parent.js

@@ -6,6 +6,7 @@ import {
   isRef,
   isProp,
   hasCleanup,
+  isUseEffect,
 } from "./util/react.js";
 import { getCallExpr, getDownstreamRefs } from "./util/ast.js";
 
@@ -27,10 +28,10 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node) || hasCleanup(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;
-      if (hasCleanup(node)) return;
 
       effectFnRefs
         .filter((ref) => isPropCallback(context, ref))

src/no-pass-live-state-to-parent.js

@@ -4,6 +4,7 @@ import {
   isImmediateCall,
   isPropCallback,
   isState,
+  isUseEffect,
 } from "./util/react.js";
 import { getCallExpr, getDownstreamRefs } from "./util/ast.js";
 
@@ -26,6 +27,7 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;

src/no-reset-all-state-on-prop-change.js

@@ -9,6 +9,7 @@ import {
   isReactFunctionalComponent,
   isReactFunctionalHOC,
   isCustomHook,
+  isUseEffect,
 } from "./util/react.js";
 
 /**
@@ -30,6 +31,7 @@ export default {
   },
   create: (context) => ({
     CallExpression: (node) => {
+      if (!isUseEffect(node)) return;
       const effectFnRefs = getEffectFnRefs(context, node);
       const depsRefs = getEffectDepsRefs(context, node);
       if (!effectFnRefs || !depsRefs) return;

src/util/react.js

@@ -98,14 +98,10 @@ export const isUseEffect = (node) =>
 
 // NOTE: When `MemberExpression` (even nested ones), a `Reference` is only the root object, not the function.
 export const getEffectFnRefs = (context, node) => {
-  if (!isUseEffect(node) || node.arguments.length < 1) {
-    return undefined;
-  }
-
   const effectFn = node.arguments[0];
   if (
-    effectFn.type !== "ArrowFunctionExpression" &&
-    effectFn.type !== "FunctionExpression"
+    effectFn?.type !== "ArrowFunctionExpression" &&
+    effectFn?.type !== "FunctionExpression"
   ) {
     return undefined;
   }
@@ -114,12 +110,8 @@ export const getEffectFnRefs = (context, node) => {
 };
 
 export function getEffectDepsRefs(context, node) {
-  if (!isUseEffect(node) || node.arguments.length < 2) {
-    return undefined;
-  }
-
   const depsArr = node.arguments[1];
-  if (depsArr.type !== "ArrayExpression") {
+  if (depsArr?.type !== "ArrayExpression") {
     return undefined;
   }