From 1a1ccaac4458fe8bee7e6d2064cf2ea5a0d02f4e Mon Sep 17 00:00:00 2001 From: Madalynn Nenninger Date: Thu, 26 Mar 2026 19:18:35 -0400 Subject: [PATCH 1/3] #3991 moved account code to left column --- .../ReimbursementFormView.tsx | 108 +++++++++--------- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx b/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx index c21e06e633..93b6e93297 100644 --- a/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx +++ b/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx @@ -439,6 +439,60 @@ const ReimbursementRequestFormView: React.FC )} + {/* Account Code */} + + + Account Code* + + { + const mappedAccountCodes = allAccountCodes + .filter((accountCode) => accountCode.allowed) + .map(accountCodesToAutocomplete); + return ( + + ); + }} + /> + {errors.accountCodeId?.message} + + {/* Refund Sources */} {/* Right Column */} - {/* Account Code */} - - - Account Code* - - { - const mappedAccountCodes = allAccountCodes - .filter((accountCode) => accountCode.allowed) - .map(accountCodesToAutocomplete); - return ( - - ); - }} - /> - {errors.accountCodeId?.message} - - {/* Upload Receipts */} Date: Thu, 26 Mar 2026 22:56:37 -0400 Subject: [PATCH 2/3] #3991 stack spacing --- .../ReimbursementRequestForm/ReimbursementFormView.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx b/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx index 93b6e93297..89fe73acd2 100644 --- a/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx +++ b/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx @@ -285,7 +285,7 @@ const ReimbursementRequestFormView: React.FC {/* Left Column */} - + {/* Vendor */} {/* Right Column */} - + {/* Upload Receipts */} Date: Thu, 2 Apr 2026 16:57:22 -0400 Subject: [PATCH 3/3] #3991 reordered stuff to make it more balanced --- .../ReimbursementFormView.tsx | 184 +++++++++--------- 1 file changed, 92 insertions(+), 92 deletions(-) diff --git a/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx b/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx index 89fe73acd2..069767f5f9 100644 --- a/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx +++ b/src/frontend/src/pages/FinancePage/ReimbursementRequestForm/ReimbursementFormView.tsx @@ -378,67 +378,6 @@ const ReimbursementRequestFormView: React.FC /> - {/* Date of Expense */} - {(isHead(user.role) || (isEditing && isLeadershipApproved)) && ( - - - - Date of Expense{isLeadershipApproved ? '*' : ''} - - - - - - ( - setDatePickerOpen(false)} - onOpen={() => setDatePickerOpen(true)} - onChange={(newValue) => { - onChange(newValue ?? new Date()); - }} - slotProps={{ - textField: { - error: !!errors.dateOfExpense, - helperText: errors.dateOfExpense?.message, - variant: 'outlined', - fullWidth: true, - size: 'small', - InputProps: { - onClick: (e) => { - const target = e.target as HTMLElement; - if (target.closest('button')) { - setDatePickerOpen(true); - } - } - } - } - }} - /> - )} - /> - - )} - {/* Account Code */} {/* Right Column */} + {/* Date of Expense */} + {(isHead(user.role) || (isEditing && isLeadershipApproved)) && ( + + + + Date of Expense{isLeadershipApproved ? '*' : ''} + + + + + + ( + setDatePickerOpen(false)} + onOpen={() => setDatePickerOpen(true)} + onChange={(newValue) => { + onChange(newValue ?? new Date()); + }} + slotProps={{ + textField: { + error: !!errors.dateOfExpense, + helperText: errors.dateOfExpense?.message, + variant: 'outlined', + fullWidth: true, + size: 'small', + InputProps: { + onClick: (e) => { + const target = e.target as HTMLElement; + if (target.closest('button')) { + setDatePickerOpen(true); + } + } + } + } + }} + /> + )} + /> + + )} + + {/* Description */} + + + Description + + ( + + )} + /> + + {/* Upload Receipts */} - - {/* Description */} - - - Description - - ( - - )} - /> -