Skip to content

check-build.sh should validate forge --version to prevent make build failing #4379

@AnkushinDaniil

Description

@AnkushinDaniil

./scripts/check-build.sh doesn't cover forge version check.
./scripts/check-build.sh can pass but make build fails with

$ FOUNDRY_PROFILE=yul forge build --skip *.sol
[⠊] Compiling...
No files changed, compilation skipped
error: expected identifier, found `<string>`
 --> yul/Reader4844.yul:1:8
  |
1 | object "Reader4844" {
  |        ^^^^^^^^^^^^

Error: Lint failed

Context:
- solar run failed
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Downgrading to

forge Version: 1.0.0-v1.0.0
Commit SHA: 8692e926198056d0228c1e166b1b6c34a5bed66c
Build Timestamp: 2025-02-10T09:05:59.911807000Z (1739178359)
Build Profile: maxperf

resolves the issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions