-
Notifications
You must be signed in to change notification settings - Fork 376
tests: more tests for InAppMessagesManager and LocationManager #2416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1eedd1d to
56b0d62
Compare
6ac301e to
b4a7360
Compare
...SDK/onesignal/location/src/test/java/com/onesignal/location/internal/LocationManagerTests.kt
Outdated
Show resolved
Hide resolved
...SDK/onesignal/location/src/test/java/com/onesignal/location/internal/LocationManagerTests.kt
Outdated
Show resolved
Hide resolved
OneSignalSDK/onesignal/testhelpers/src/main/java/com/onesignal/mocks/IOMockHelper.kt
Outdated
Show resolved
Hide resolved
OneSignalSDK/onesignal/testhelpers/src/main/java/com/onesignal/mocks/IOMockHelper.kt
Show resolved
Hide resolved
OneSignalSDK/onesignal/testhelpers/src/main/java/com/onesignal/mocks/IOMockHelper.kt
Show resolved
Hide resolved
OneSignalSDK/onesignal/testhelpers/src/main/java/com/onesignal/mocks/IOMockHelper.kt
Outdated
Show resolved
Hide resolved
OneSignalSDK/onesignal/testhelpers/src/main/java/com/onesignal/mocks/IOMockHelper.kt
Show resolved
Hide resolved
...app-messages/src/test/java/com/onesignal/inAppMessages/internal/InAppMessagesManagerTests.kt
Outdated
Show resolved
Hide resolved
...app-messages/src/test/java/com/onesignal/inAppMessages/internal/InAppMessagesManagerTests.kt
Outdated
Show resolved
Hide resolved
...app-messages/src/test/java/com/onesignal/inAppMessages/internal/InAppMessagesManagerTests.kt
Outdated
Show resolved
Hide resolved
...app-messages/src/test/java/com/onesignal/inAppMessages/internal/InAppMessagesManagerTests.kt
Outdated
Show resolved
Hide resolved
...SDK/onesignal/location/src/test/java/com/onesignal/location/internal/LocationManagerTests.kt
Outdated
Show resolved
Hide resolved
...SDK/onesignal/location/src/test/java/com/onesignal/location/internal/LocationManagerTests.kt
Outdated
Show resolved
Hide resolved
...SDK/onesignal/location/src/test/java/com/onesignal/location/internal/LocationManagerTests.kt
Outdated
Show resolved
Hide resolved
...SDK/onesignal/location/src/test/java/com/onesignal/location/internal/LocationManagerTests.kt
Outdated
Show resolved
Hide resolved
...app-messages/src/test/java/com/onesignal/inAppMessages/internal/InAppMessagesManagerTests.kt
Show resolved
Hide resolved
8b72576 to
288325e
Compare
5d5c256 to
a9b001c
Compare
a9b001c to
c875f72
Compare
OneSignalSDK/onesignal/testhelpers/src/main/java/com/onesignal/mocks/IOMockHelper.kt
Show resolved
Hide resolved
...app-messages/src/test/java/com/onesignal/inAppMessages/internal/InAppMessagesManagerTests.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2416 (comment)
triggerModelSlots is a list of TriggerModel captured when add() is called by the triggerModelStore so we can't directly compare with a list of maps. I updated a new version for better readability.
OneSignalSDK/onesignal/testhelpers/src/main/java/com/onesignal/mocks/IOMockHelper.kt
Show resolved
Hide resolved
OneSignalSDK/onesignal/testhelpers/src/main/java/com/onesignal/mocks/IOMockHelper.kt
Outdated
Show resolved
Hide resolved
6495fd3 to
47ba05b
Compare
|
CI fails due to a flaky test in StartupService. Will address it in a separate PR. |
Description
One Line Summary
Add more tests for InAppMessagesManager and LocationManager to improve test coverage.
Production Code Change
All usages of Build.VERSION.SDK_INT in LocationManager.kt have been refactored to use AndroidUtils.androidSDKInt for better flexibility when mocking the Android API level in tests.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is