short url not generating issue

[Lungsangg]

Description :
when trying to share a segment, short url is not generating and there is an 500 Internal Server Error

Implementation :

• short url issue fix
• fix 500 status code error

[dhakar66]

waiting for kunsang to update.

@Lungsangg please get more details and update this card in bit detail for better understanding.

[Lungsangg]

Issue 1 :

TypeError: generate_id() missing 1 required positional argument: 'pk'

What was wrong:

generate_id was written to take a number (a “slot” / sequence number) and turn it into a 3-character short code. The shorten code still called it with no argument and treated the result like a big number to pass into base62.encode. That didn’t match the real function anymore.

What we did:

We made URL shortening work like the text-shortening flow: pick a sequence number, call generate_id(that_number) to get the short code, and use that string as the short URL segment.

Issue 2 :

"Short code capacity exhausted (62^3)"

What was wrong:

We tied two different things to the same number: max(id) + 1 was used both as the database row id and as the input to generate_id.
generate_id only makes sense for numbers up to about 62³ (three-character codes). If old rows already had very large ids, max(id) + 1 was huge, so the app thought you were “out of codes” immediately, even if you only had a few links.

What we did:

Split them:
Row id: still max(id) + 1 so every row gets a unique id, even with legacy big ids.
Short code: use how many URL rows you have + 1 (and bump if that code is taken), same idea as text redirects, so that number stays in the valid range for 3-character codes.