refactor: badge component to use internal icons for some status (#1136) (#1153)

Closes #1136

Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>

Author: ludovic35

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+-  Update `badge` to use internal icons for some status (Orange-OpenSource/ouds-ios#1136)
 - `SwiftFormat` Swift package plugin from v0.58.5 to v0.58.6
 - `actions/dependency-review-action` action from v4.8.1 to v4.8.2 for `dependency-review` workflow
 - `color` semantic tokens (tokens libraries Core v1.9, System v2.2)

OUDS/Core/Components/Sources/Actions/Button/OUDSButton.swift

@@ -14,7 +14,7 @@
 import OUDSFoundations
 import SwiftUI
 
-// MARK: - OUDSThemesContract Button
+// MARK: - OUDS Button
 
 /// The ``OUDSButton`` proposes layout with text only, icon only or text with icon.
 ///
@@ -137,7 +137,7 @@ public struct OUDSButton: View {
         case textAndIcon(text: String, icon: Image, flipIcon: Bool)
     }
 
-    /// Represents the appearance of an OUDSThemesContract button, i.e. a kind of type
+    /// Represents the appearance of an OUDS button, i.e. a kind of type
     public enum Appearance {
         /// Default button is used for action
         case `default`

OUDS/Core/Components/Sources/Controls/Checkbox/Internal/CheckboxIndicator.swift

@@ -72,7 +72,7 @@ struct CheckboxIndicator: View {
             case .pressed:
                 theme.colors.actionNegativePressed
             case .disabled, .readOnly:
-                OL.fatal("An OUDSThemesContract Checkbox with a disabled state / read only mode and an error situation has been detected, which is not allowed"
+                OL.fatal("An OUDS Checkbox with a disabled state / read only mode and an error situation has been detected, which is not allowed"
                     + " Only non-error situation are allowed to have a disabled state / read only mode.")
             }
 

OUDS/Core/Components/Sources/Controls/Checkbox/Internal/CheckboxIndicatorModifiers.swift

@@ -98,7 +98,7 @@ private struct CheckboxIndicatorForegroundModifier: ViewModifier {
 
     private var disabledColor: MultipleColorSemanticTokens {
         guard !isError else {
-            OL.fatal("An OUDSThemesContract Checkbox with a disabled state and an error situation has been detected, which is not allowed."
+            OL.fatal("An OUDS Checkbox with a disabled state and an error situation has been detected, which is not allowed."
                 + " Only non-error situation are allowed to have a disabled state.")
         }
         return theme.colors.actionDisabled
@@ -153,7 +153,7 @@ private struct CheckboxIndicatorBackgroundModifier: ViewModifier {
 
     private var disabledColor: Color {
         guard !isError else {
-            OL.fatal("An OUDSThemesContract Checkbox with a disabled state and an error situation has been detected, which is not allowed."
+            OL.fatal("An OUDS Checkbox with a disabled state and an error situation has been detected, which is not allowed."
                 + " Only non-error situation are allowed to have a disabled state.")
         }
         return Color.clear
@@ -234,7 +234,7 @@ private struct CheckboxIndicatorBorderModifier: ViewModifier {
 
     private var disabledColor: MultipleColorSemanticTokens {
         guard !isError else {
-            OL.fatal("An OUDSThemesContract Checkbox with a disabled state and an error situation has been detected, which is not allowed"
+            OL.fatal("An OUDS Checkbox with a disabled state and an error situation has been detected, which is not allowed"
                 + " Only non-error situation are allowed to have a disabled state.")
         }
         return theme.colors.actionDisabled

OUDS/Core/Components/Sources/Controls/Checkbox/OUDSCheckbox.swift

@@ -15,7 +15,7 @@ import OUDSFoundations
 import OUDSTokensComponent
 import SwiftUI
 
-// MARK: - OUDSThemesContract Checkbox
+// MARK: - OUDS Checkbox
 
 /// The ``OUDSCheckbox`` proposes layout to add in your views a lonely checkbox, without labels, texts nor icons components.
 /// If you want to use a checkbox with additional texts and icon, prefer instead ``OUDSCheckboxItem``.
@@ -38,7 +38,7 @@ import SwiftUI
 /// Note also the component must be instanciated with a string parameter used as accessibility label.
 /// It is a good pratice (at least) to define a label for a component without text for accessibility reasons. This label will be vocalized by *Voice Over*.
 /// The vocalization tool will also use, after the label, a description of the component (if disabled, if error context), and a fake trait for checkbox.
-/// No accessibility identifier is defined in OUDSThemesContract side as this value remains in the users hands.
+/// No accessibility identifier is defined in OUDS side as this value remains in the users hands.
 ///
 /// ## Cases forbidden by design
 ///

OUDS/Core/Components/Sources/Controls/Checkbox/OUDSCheckboxIndeterminate.swift

@@ -15,7 +15,7 @@ import OUDSFoundations
 import OUDSTokensComponent
 import SwiftUI
 
-// MARK: - OUDSThemesContract Checkbox Indeterminate
+// MARK: - OUDS Checkbox Indeterminate
 
 /// The ``OUDSCheckboxIndeterminate`` proposes layout to add in your views a lonely checkbox, without labels, texts nor icons components.
 /// If you want to use a checkbox with additional texts and icon, prefer instead ``OUDSCheckboxItem``.

OUDS/Core/Components/Sources/Controls/Checkbox/OUDSCheckboxItem.swift

@@ -14,7 +14,7 @@
 import OUDSFoundations
 import SwiftUI
 
-// MARK: - OUDSThemesContract Checkbox Item
+// MARK: - OUDS Checkbox Item
 
 /// The ``OUDSCheckboxItem`` proposes layouts to add in your views some checkboxes components with labels and icons.
 /// If you want to use a checkbox with only an indicator prefer instead ``OUDSCheckbox``.
@@ -52,7 +52,7 @@ import SwiftUI
 /// ## Accessibility considerations
 ///
 /// *Voice Over* will use several elements to describe the component: if component disabled / read only, if error context, the label and helper texts and a custom checkbox trait.
-/// No accessibility identifier is defined in OUDSThemesContract side as this value remains in the users hands.
+/// No accessibility identifier is defined in OUDS side as this value remains in the users hands.
 ///
 /// ## Forbidden by design
 ///

OUDS/Core/Components/Sources/Controls/Checkbox/OUDSCheckboxItemIndeterminate.swift

@@ -14,7 +14,7 @@
 import OUDSFoundations
 import SwiftUI
 
-// MARK: - OUDSThemesContract Checkbox Item Indeterminate
+// MARK: - OUDS Checkbox Item Indeterminate
 
 /// The ``OUDSCheckboxItemIndeterminate`` proposes layouts to add in your views some checkboxes components.
 /// If you want to use a checkbox with only an indicator prefer instead ``OUDSCheckboxIndeterminate``.

OUDS/Core/Components/Sources/Controls/CheckboxPicker/OUDSCheckboxPicker.swift

@@ -83,7 +83,7 @@ import SwiftUI
 ///
 /// ## Design documentation
 ///
-/// There is no online specification as this component is not an official OUDSThemesContract one
+/// There is no online specification as this component is not an official OUDS one
 ///
 /// ## Themes rendering
 ///

OUDS/Core/Components/Sources/Controls/Chip/Internal/ChipInteractionState.swift

@@ -38,7 +38,7 @@ enum ChipInteractionState {
         case .disabled:
             self = .disabled
         case .readOnly:
-            OL.fatal("An OUDSThemesContract chip is a component which cannot be in read-only mode")
+            OL.fatal("An OUDS chip is a component which cannot be in read-only mode")
         }
     }
 }