Skip to content

Pull BNpcName sheet data into resource #1112

Description

@valarnin

To avoid manually mapping name data, we should pull in names as a resource.

Blindly pulling in all names might be a bit excessive as far as file size and load on XIVAPI, so we may want to filter to only the names we're actively using via a BNpcNameId map, e.g.:

const requiredNameIds = [
  6052, // Exdeath
];

// ... query XIVAPI for required names

Alternatively, if we want to pull all names, we should pull from the base CSVs instead, as there are a lot of entries.


Unrelated to this PR, it feels pretty bad to pull in localization information like this manually. Maybe we should have a BNpcName resource (e.g. resources/npc_names.ts) that pulls cached info from XIVAPI?

Originally posted by @valarnin in #1080 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions