support and test full filespec definitions

Author: hobu

src/pdal/pipeline.py

@@ -220,9 +220,11 @@ def __init__(self, filename: Optional[str] = None, **options: Any):
             if isinstance(filename, dict):
                 if "path" not in filename:
                     raise ValueError(f"'path' is missing in the provided filespec: {filename}")
-                options["filename"] = filename["path"]
-            else:
                 options["filename"] = filename
+
+            else:
+                filespec = {'path':str(filename)}
+                options["filename"] = filespec
         super().__init__(**options)
 
     @property
@@ -231,7 +233,15 @@ def type(self) -> str:
             return super().type
         except KeyError:
             filename = self._options.get("filename")
-            return str(self._infer_type(filename) if filename else "")
+            if isinstance(filename, dict):
+                if "path" not in filename:
+                    raise ValueError(f"'path' is missing in the provided filespec: {filename}")
+                path = filename.get('path')
+            else:
+                path = str(filename)
+
+
+            return str(self._infer_type(path) if filename else "")
 
     _infer_type = staticmethod(lambda filename: "")
 

test/test_pipeline.py

@@ -290,6 +290,13 @@ def test_infer_stage_type(self):
         assert pdal.Reader({}).type == ""
         assert pdal.Writer({}).type == ""
 
+    def test_filespec(self):
+        """Can transit filespecs"""
+        spec = {'path':'junk.las', 'headers':{'header1':'header_1', 'header2':'header_2'}, 'query':{'query1':'query_1', 'query2':'query_2'}}
+        assert pdal.Reader(spec).type == "readers.las"
+        assert pdal.Reader(spec).options['filename']['path'] == "junk.las"
+        assert pdal.Writer("foo.las").type == "writers.las"
+
     def test_streamable(self):
         """Can we distinguish streamable from non-streamable stages and pipeline"""
         rs = pdal.Reader(type="readers.las", filename="foo")