Generic/DisallowYodaConditions: improve code coverage

Includes removing two unreachable conditions

The first condition is unreachable because PHPCS will never call
DisallowYodaConditionsSniff::process() if there is no non-empty token before a
comparison token. Even if the file contains a syntax error, there must
be at least a PHP opening tag before the comparison token for the method
to be called.

The second condition is unreachable because at this point in the code
there will always be at least two non-empty tokens before the comparison
token. If there is only one, it must be a PHP opening tag and, in this
case, the method will bail before reaching the code that sets the
`$prevIndex` variable.

This commit also documents why a certain line is uncovered by tests - and cannot be
covered, nor can it be removed as external sniffs may call
`DisallowYodaConditionsSniff::isArrayStatic()` directly.

Author: rodrigoprimo

src/Standards/Generic/Sniffs/ControlStructures/DisallowYodaConditionsSniff.php

@@ -57,9 +57,7 @@ public function process(File $phpcsFile, $stackPtr)
             T_CONSTANT_ENCAPSED_STRING,
         ];
 
-        if ($previousIndex === false
-            || in_array($tokens[$previousIndex]['code'], $relevantTokens, true) === false
-        ) {
+        if (in_array($tokens[$previousIndex]['code'], $relevantTokens, true) === false) {
             return;
         }
 
@@ -71,9 +69,6 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         $prevIndex = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($previousIndex - 1), null, true);
-        if ($prevIndex === false) {
-            return;
-        }
 
         if (in_array($tokens[$prevIndex]['code'], Tokens::$arithmeticTokens, true) === true) {
             return;
@@ -150,6 +145,7 @@ public function isArrayStatic(File $phpcsFile, $arrayToken)
             $start = $tokens[$arrayToken]['parenthesis_opener'];
             $end   = $tokens[$arrayToken]['parenthesis_closer'];
         } else {
+            // Shouldn't be possible but may happen if external sniffs are using this method.
             return true;
         }
 

src/Standards/Generic/Tests/ControlStructures/DisallowYodaConditionsUnitTest.inc

@@ -175,3 +175,13 @@ echo match ($text) {
 };
 
 1 ?? $nullCoalescingShouldNotTriggerSniff;
+
+1 + 2 === $sniffBailsArithmeticToken;
+
+'string' . 'concat' === $sniffBailsStringConcatToken;
+
+1 != $value;
+1 <> $value;
+1 >= $value;
+1 <= $value;
+1 <=> $value;

src/Standards/Generic/Tests/ControlStructures/DisallowYodaConditionsUnitTest.php

@@ -67,6 +67,11 @@ public function getErrorList()
             167 => 1,
             173 => 1,
             174 => 1,
+            183 => 1,
+            184 => 1,
+            185 => 1,
+            186 => 1,
+            187 => 1,
         ];
 
     }//end getErrorList()