feat: add discription to RuleS2S spec

Author: gozdan-lordz

api/v1alpha1/rules2s_types.go

@@ -37,6 +37,9 @@ type RuleS2SSpec struct {
 	// ServiceRef is a reference to the target service
 	// +kubebuilder:validation:Required
 	ServiceRef NamespacedObjectReference `json:"serviceRef"`
+
+	// +optional
+	Description string `json:"description,omitempty"`
 }
 
 // RuleS2SStatus defines the observed state of RuleS2S.

config/crd/bases/netguard.sgroups.io_rules2ses.yaml

@@ -39,6 +39,8 @@ spec:
           spec:
             description: RuleS2SSpec defines the desired state of RuleS2S.
             properties:
+              description:
+                type: string
               serviceLocalRef:
                 description: ServiceLocalRef is a reference to the local service
                 properties:

internal/controller/rules2s_controller.go

@@ -1761,7 +1761,7 @@ func (r *RuleS2SReconciler) couldBeLegacyRuleForRuleS2S(
 		return false
 	}
 
-	// Check if rule has empty ports (the main indicator of the problem we're fixing)
+	// Check if rule has empty ports
 	if len(rule.Spec.Ports) > 0 && rule.Spec.Ports[0].D == "" {
 		// This is likely an orphaned rule with empty ports that should be deleted
 		return true