Skip to content

Commit e0b18f6

Browse files
committed
Drop Qt5 support
1 parent 47ad32f commit e0b18f6

File tree

5 files changed

+19
-42
lines changed

5 files changed

+19
-42
lines changed

CMakeLists.txt

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,8 @@ include(GNUInstallDirs)
1919

2020
set(QPACKAGEKIT_API_LEVEL "1")
2121

22-
option(BUILD_WITH_QT5 "Use Qt5 instead of Qt6" OFF)
2322

24-
if(BUILD_WITH_QT5)
25-
set(QT_VERSION_MAJOR 5)
26-
else()
27-
set(QT_VERSION_MAJOR 6)
28-
endif()
29-
30-
find_package(Qt${QT_VERSION_MAJOR} 5.10 REQUIRED COMPONENTS Core DBus)
23+
find_package(Qt6 6.8 REQUIRED COMPONENTS Core DBus)
3124

3225
add_definitions(
3326
-DQT_NO_KEYWORDS
@@ -63,7 +56,7 @@ set(CMAKE_VISIBILITY_INLINES_HIDDEN 1)
6356
set (GETTEXT_PACKAGE "packagekit")
6457
set (VERSION "${QPACKAGEKIT_VERSION}")
6558
set (LOCALSTATEDIR "/var")
66-
set (CMAKECONFIG_INSTALL_DIR "${CMAKE_INSTALL_LIBDIR}/cmake/packagekitqt${QT_VERSION_MAJOR}/")
59+
set (CMAKECONFIG_INSTALL_DIR "${CMAKE_INSTALL_LIBDIR}/cmake/packagekitqt6/")
6760

6861
add_definitions("-DLOCALSTATEDIR=\"${LOCALSTATEDIR}\"")
6962
set (CMAKE_CXX_STANDARD 17)

src/CMakeLists.txt

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,30 +42,25 @@ endif ()
4242
set_source_files_properties(${PK_INTERFACE_XML} PROPERTIES NO_NAMESPACE true)
4343
set_source_files_properties(${PK_TRANSACTION_INTERFACE_XML} PROPERTIES NO_NAMESPACE true)
4444

45-
if(${QT_VERSION_MAJOR} EQUAL 6)
4645
qt6_add_dbus_interface(packagekitqt_SRC ${PK_INTERFACE_XML} daemonproxy)
4746
qt6_add_dbus_interface(packagekitqt_SRC ${PK_TRANSACTION_INTERFACE_XML} transactionproxy)
48-
else()
49-
qt5_add_dbus_interface(packagekitqt_SRC ${PK_INTERFACE_XML} daemonproxy)
50-
qt5_add_dbus_interface(packagekitqt_SRC ${PK_TRANSACTION_INTERFACE_XML} transactionproxy)
51-
endif()
5247

53-
add_library(packagekitqt${QT_VERSION_MAJOR} ${packagekitqt_SRC} ${packagekitqt_HEADERS} ${packagekitqt_HEADERS_PRIVATE})
54-
set_target_properties(packagekitqt${QT_VERSION_MAJOR} PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION ${QPACKAGEKIT_API_LEVEL})
48+
add_library(packagekitqt ${packagekitqt_SRC} ${packagekitqt_HEADERS} ${packagekitqt_HEADERS_PRIVATE})
49+
set_target_properties(packagekitqt PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION ${QPACKAGEKIT_API_LEVEL})
5550

56-
target_link_libraries(packagekitqt${QT_VERSION_MAJOR} PUBLIC Qt${QT_VERSION_MAJOR}::DBus)
51+
target_link_libraries(packagekitqt PUBLIC Qt6::DBus)
5752

58-
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/packagekitqt${QT_VERSION_MAJOR}.pc.in
59-
${CMAKE_CURRENT_BINARY_DIR}/packagekitqt${QT_VERSION_MAJOR}.pc
53+
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/packagekitqt.pc.in
54+
${CMAKE_CURRENT_BINARY_DIR}/packagekitqt6.pc
6055
@ONLY
6156
)
62-
target_include_directories(packagekitqt${QT_VERSION_MAJOR} INTERFACE "$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}/packagekitqt${QT_VERSION_MAJOR}/PackageKit/;${CMAKE_INSTALL_INCLUDEDIR}/packagekitqt${QT_VERSION_MAJOR}>")
63-
install(TARGETS packagekitqt${QT_VERSION_MAJOR} EXPORT PackageKitQtTargets DESTINATION ${CMAKE_INSTALL_LIBDIR})
64-
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/packagekitqt${QT_VERSION_MAJOR}.pc
57+
target_include_directories(packagekitqt INTERFACE "$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}/PackageKitQt/PackageKit/;${CMAKE_INSTALL_INCLUDEDIR}/PackageKitQt>")
58+
install(TARGETS packagekitqt EXPORT PackageKitQtTargets DESTINATION ${CMAKE_INSTALL_LIBDIR})
59+
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/packagekitqt.pc
6560
DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig
6661
)
6762
install(FILES ${packagekitqt_HEADERS} ${QPK_VERSION_HDR}
68-
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/packagekitqt${QT_VERSION_MAJOR}/PackageKit/
63+
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/PackageKitQt/PackageKit/
6964
)
7065

7166
add_subdirectory(modules)

src/modules/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ include(CMakePackageConfigHelpers)
22

33
configure_package_config_file(
44
${CMAKE_CURRENT_SOURCE_DIR}/packagekit-qt-config.cmake.in
5-
${CMAKE_CURRENT_BINARY_DIR}/packagekitqt${QT_VERSION_MAJOR}-config.cmake
6-
INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/packagekitqt${QT_VERSION_MAJOR}/
5+
${CMAKE_CURRENT_BINARY_DIR}/packagekitqt6-config.cmake
6+
INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/packagekitqt6/
77
)
88

9-
write_basic_package_version_file(${CMAKE_CURRENT_BINARY_DIR}/packagekitqt${QT_VERSION_MAJOR}-config-version.cmake VERSION ${PROJECT_VERSION} COMPATIBILITY SameMajorVersion)
9+
write_basic_package_version_file(${CMAKE_CURRENT_BINARY_DIR}/packagekitqt6-config-version.cmake VERSION ${PROJECT_VERSION} COMPATIBILITY SameMajorVersion)
1010

11-
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/packagekitqt${QT_VERSION_MAJOR}-config.cmake
12-
${CMAKE_CURRENT_BINARY_DIR}/packagekitqt${QT_VERSION_MAJOR}-config-version.cmake
13-
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/packagekitqt${QT_VERSION_MAJOR}/
11+
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/packagekitqt6-config.cmake
12+
${CMAKE_CURRENT_BINARY_DIR}/packagekitqt6-config-version.cmake
13+
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/packagekitqt6/
1414
)

src/packagekitqt6.pc.in renamed to src/packagekitqt.pc.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ Name: @LIBNAME@
77
Description: PackageKit is a package management abstraction layer.
88
Version: @PROJECT_VERSION@
99
Requires: Qt6Core, Qt6DBus
10-
Libs: -L${libdir} -lpackagekitqt6
11-
Cflags: -I${includedir}/packagekitqt6
10+
Libs: -L${libdir} -lpackagekitqt
11+
Cflags: -I${includedir}/PackageKitQt

src/packagekitqt5.pc.in

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)