Change public classes to internal across codebase (#2715)

Author: IhateTrains

.github/workflows/create_release.yml

@@ -112,10 +112,10 @@ jobs:
       run: |
         dotnet tool install --global dotnet-innosetup --version 6.2.1
         cp Fronter.NET/Fronter.NET/Assets/converter.ico Publish/Assets/
-        dotnet iscc --version
+        iscc --version
         sed -i '5i\\#define MyAppVersion "${{ needs.create_release.outputs.tag }}"' ImperatorToCK3.iss
         cat ImperatorToCK3.iss
-        dotnet iscc ImperatorToCK3.iss
+        iscc ImperatorToCK3.iss
     - name: "Upload installer for Windows"
       id: upload-installer
       if: matrix.build == 'win-x64'

ImperatorToCK3/CK3/Armies/MenAtArmsCost.cs

@@ -5,7 +5,7 @@
 namespace ImperatorToCK3.CK3.Armies;
 
 [SerializationByProperties]
-public sealed partial class MenAtArmsCost : IPDXSerializable {
+internal sealed partial class MenAtArmsCost : IPDXSerializable {
 	[SerializedName("gold")] public double? Gold { get; set; }
 	[SerializedName("piety")] public double? Piety { get; set; }
 	[SerializedName("prestige")] public double? Prestige { get; set; }

ImperatorToCK3/CK3/Characters/Pregnancy.cs

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.CK3.Characters;
 
-public sealed class Pregnancy {
+internal sealed class Pregnancy {
 	public string FatherId { get; init; }
 	public string MotherId { get; init; }
 	public Date BirthDate { get; init; }

ImperatorToCK3/CK3/Cultures/NameList.cs

@@ -3,9 +3,9 @@
 using System.Collections.Generic;
 using System.Text.RegularExpressions;
 
-namespace ImperatorToCK3.CK3.Cultures; 
+namespace ImperatorToCK3.CK3.Cultures;
 
-public sealed partial class NameList : IIdentifiable<string> {
+internal sealed partial class NameList : IIdentifiable<string> {
 	public string Id { get; }
 	private readonly OrderedSet<string> maleNames = [];
 	private readonly OrderedSet<string> femaleNames = [];

ImperatorToCK3/CK3/Dynasties/House.cs

@@ -6,7 +6,7 @@
 namespace ImperatorToCK3.CK3.Dynasties;
 
 [SerializationByProperties]
-public sealed partial class House : IPDXSerializable, IIdentifiable<string> {
+internal sealed partial class House : IPDXSerializable, IIdentifiable<string> {
 	[NonSerialized] public string Id { get; }
 
 	[SerializedName("prefix")] public string? Prefix { get; private set; }

ImperatorToCK3/CK3/Legends/LegendSeed.cs

@@ -4,7 +4,7 @@
 
 namespace ImperatorToCK3.CK3.Legends;
 
-public sealed class LegendSeed : IIdentifiable<string>, IPDXSerializable {
+internal sealed class LegendSeed : IIdentifiable<string>, IPDXSerializable {
 	public string Id { get; }
 	private StringOfItem Body { get; }
 

ImperatorToCK3/CK3/Legends/LegendSeedCollection.cs

@@ -6,7 +6,7 @@
 
 namespace ImperatorToCK3.CK3.Legends;
 
-public sealed class LegendSeedCollection : ConcurrentIdObjectCollection<string, LegendSeed>, IPDXSerializable {
+internal sealed class LegendSeedCollection : ConcurrentIdObjectCollection<string, LegendSeed>, IPDXSerializable {
 	public void LoadSeeds(ModFilesystem ck3ModFS) {
 		Logger.Info("Loading legend seeds...");
 

ImperatorToCK3/CK3/Localization/CK3LocBlock.cs

@@ -5,7 +5,7 @@
 
 namespace ImperatorToCK3.CK3.Localization;
 
-public class CK3LocBlock : IIdentifiable<string> { // TODO: add ILocBlock interface that both this and commonItems' LocBlock would implement.
+internal class CK3LocBlock : IIdentifiable<string> { // TODO: add ILocBlock interface that both this and commonItems' LocBlock would implement.
 	private readonly string baseLanguage;
 	private readonly ConcurrentDictionary<string, (string, CK3LocType)> localizations = new();
 

ImperatorToCK3/CK3/Provinces/ProvinceMappings.cs

@@ -22,7 +22,7 @@ namespace ImperatorToCK3.CK3.Provinces;
 /// </para>
 /// <para>Now 6874 history is same as 6872 history.</para>
 /// </summary>
-public sealed class ProvinceMappings : Dictionary<ulong, ulong> {
+internal sealed class ProvinceMappings : Dictionary<ulong, ulong> {
 	public ProvinceMappings(ModFilesystem ck3ModFS) {
 		var parser = new Parser();
 		RegisterKeys(parser);

ImperatorToCK3/CK3/Religions/DoctrineCategory.cs

@@ -3,14 +3,14 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 
-namespace ImperatorToCK3.CK3.Religions; 
+namespace ImperatorToCK3.CK3.Religions;
 
-public sealed class DoctrineCategory : IIdentifiable<string> {
+internal sealed class DoctrineCategory : IIdentifiable<string> {
 	public string Id { get; }
 	public string? GroupId { get; private set; }
 	public int NumberOfPicks { get; private set; } = 1;
 
-	private readonly OrderedSet<string> doctrineIds = new();
+	private readonly OrderedSet<string> doctrineIds = [];
 	public IReadOnlyCollection<string> DoctrineIds => doctrineIds.ToImmutableArray();
 
 	public DoctrineCategory(string id, BufferedReader categoryReader) {