Remove all many-to-many province mappings (#2609)

The converter also logs a warning when such a mapping is found.

closes #2435

Author: IhateTrains

ImperatorToCK3/CK3/Characters/CharacterCollection.cs

@@ -435,7 +435,7 @@ public void LoadCharacterIDsToPreserve(Date ck3BookmarkDate) {
 
 		const string configurablePath = "configurables/ck3_characters_to_preserve.txt";
 		var parser = new Parser();
-		parser.RegisterRegex("keep_as_is", reader => {
+		parser.RegisterKeyword("keep_as_is", reader => {
 			var ids = reader.GetStrings();
 			foreach (var id in ids) {
 				if (!TryGetValue(id, out var character)) {

ImperatorToCK3/Data_Files/configurables/province_mappings/imperator_invictus.txt

@@ -1,10 +1,11 @@
 using commonItems;
 using ImperatorToCK3.CommonUtils;
 using System.Collections.Generic;
+using System.Text.RegularExpressions;
 
 namespace ImperatorToCK3.Imperator.Diplomacy;
 
-internal sealed class War {
+internal sealed partial class War {
 	public Date StartDate { get; private set; } = new(1, 1, 1);
 	public bool Previous { get; private set; }
 	public List<ulong> AttackerCountryIds { get; } = [];
@@ -23,7 +24,7 @@ static War() {
 		parser.RegisterKeyword("defender", reader => {
 			warToReturn.DefenderCountryIds.Add(reader.GetULong());
 		});
-		parser.RegisterRegex(WargoalTypeRegex, reader => {
+		parser.RegisterRegex(wargoalTypeRegex, reader => {
 			var wargoalParser = new Parser();
 			wargoalParser.RegisterKeyword("type", typeReader =>
 				warToReturn.WarGoal = typeReader.GetString()
@@ -43,10 +44,14 @@ public static War Parse(BufferedReader reader) {
 		return warToReturn;
 	}
 
-	// Wargoal types seem to be hardcoded, they don't need to be loaded from game files.
-	private const string WargoalTypeRegex = "take_province|naval_superiority|superiority|enforce_military_access|independence";
+	private static readonly Regex wargoalTypeRegex = WargoalTypeRegex();
 
 	private static readonly Parser parser = new();
 	private static War warToReturn = new();
-	public static IgnoredKeywordsSet IgnoredTokens { get; } = new();
+	public static IgnoredKeywordsSet IgnoredTokens { get; } = [];
+
+	// Wargoal types seem to be hardcoded, they don't need to be loaded from game files.
+	private const string WargoalTypeRegexStr = "take_province|naval_superiority|superiority|enforce_military_access|independence";
+	[GeneratedRegex(WargoalTypeRegexStr, RegexOptions.Compiled)]
+	private static partial Regex WargoalTypeRegex();
 }

ImperatorToCK3/Data_Files/configurables/province_mappings/imperator_vanilla.txt

@@ -336,7 +336,7 @@ private void ParseSave(Configuration config, ConverterVersion converterVersion,
 
 		Thread? localCoaExtractThread = null;
 
-		parser.RegisterRegex(@"\bSAV\w*\b", _ => { });
+		parser.RegisterRegex(SaveStartRegex(), _ => { });
 		parser.RegisterKeyword("version", reader => VerifySaveVersion(converterVersion, reader));
 		parser.RegisterKeyword("date", reader => LoadSaveDate(config, reader));
 		parser.RegisterKeyword("enabled_dlcs", LogEnabledDLCs);
@@ -795,6 +795,8 @@ private static BufferedReader ProcessCompressedEncodedSave(string saveGamePath)
 
 	private readonly IgnoredKeywordsSet ignoredTokens = [];
 
+	[GeneratedRegex(@"\bSAV\w*\b")]
+	private static partial Regex SaveStartRegex();
 	[GeneratedRegex(@"^\S+=\s*\{[\s\S]*?^\}", RegexOptions.Multiline)]
 	private static partial Regex FlagDefinitionRegex();
 	[GeneratedRegex(@"\$[A-Z_]*\$")]

ImperatorToCK3/Imperator/Diplomacy/War.cs

@@ -37,6 +37,11 @@ private void CreateMappings(ProvinceMappingsVersion mappingsVersion) {
 				continue;
 			}
 
+			// We don't want many-to-many mappings.
+			if (mapping.ImperatorProvinces.Count > 1 && mapping.CK3Provinces.Count > 1) {
+				Logger.Warn($"Many-to-many province mapping found: {string.Join(", ", mapping.ImperatorProvinces)} -> {string.Join(", ", mapping.CK3Provinces)}");
+			}
+
 			foreach (var impNumber in mapping.ImperatorProvinces) {
 				if (impNumber != 0) {
 					imperatorToCK3ProvinceMap.Add(impNumber, mapping.CK3Provinces);