ParadoxGameConverters · IhateTrains · Sep 12, 2025 · Sep 12, 2025 · Sep 12, 2025
@@ -112,10 +112,10 @@ jobs:
       run: |
         dotnet tool install --global dotnet-innosetup --version 6.2.1
         cp Fronter.NET/Fronter.NET/Assets/converter.ico Publish/Assets/
-        dotnet iscc --version
+        iscc --version
         sed -i '5i\\#define MyAppVersion "${{ needs.create_release.outputs.tag }}"' ImperatorToCK3.iss
         cat ImperatorToCK3.iss
-        dotnet iscc ImperatorToCK3.iss
+        iscc ImperatorToCK3.iss
     - name: "Upload installer for Windows"
       id: upload-installer
       if: matrix.build == 'win-x64'

@@ -5,7 +5,7 @@
 namespace ImperatorToCK3.CK3.Armies;
 
 [SerializationByProperties]
-public sealed partial class MenAtArmsCost : IPDXSerializable {
+internal sealed partial class MenAtArmsCost : IPDXSerializable {
 	[SerializedName("gold")] public double? Gold { get; set; }
 	[SerializedName("piety")] public double? Piety { get; set; }
 	[SerializedName("prestige")] public double? Prestige { get; set; }

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.CK3.Characters;
 
-public sealed class Pregnancy {
+internal sealed class Pregnancy {
 	public string FatherId { get; init; }
 	public string MotherId { get; init; }
 	public Date BirthDate { get; init; }

@@ -3,9 +3,9 @@
 using System.Collections.Generic;
 using System.Text.RegularExpressions;
 
-namespace ImperatorToCK3.CK3.Cultures; 
+namespace ImperatorToCK3.CK3.Cultures;
 
-public sealed partial class NameList : IIdentifiable<string> {
+internal sealed partial class NameList : IIdentifiable<string> {
 	public string Id { get; }
 	private readonly OrderedSet<string> maleNames = [];
 	private readonly OrderedSet<string> femaleNames = [];

@@ -6,7 +6,7 @@
 namespace ImperatorToCK3.CK3.Dynasties;
 
 [SerializationByProperties]
-public sealed partial class House : IPDXSerializable, IIdentifiable<string> {
+internal sealed partial class House : IPDXSerializable, IIdentifiable<string> {
 	[NonSerialized] public string Id { get; }
 
 	[SerializedName("prefix")] public string? Prefix { get; private set; }

@@ -4,7 +4,7 @@
 
 namespace ImperatorToCK3.CK3.Legends;
 
-public sealed class LegendSeed : IIdentifiable<string>, IPDXSerializable {
+internal sealed class LegendSeed : IIdentifiable<string>, IPDXSerializable {
 	public string Id { get; }
 	private StringOfItem Body { get; }
 

@@ -6,7 +6,7 @@
 
 namespace ImperatorToCK3.CK3.Legends;
 
-public sealed class LegendSeedCollection : ConcurrentIdObjectCollection<string, LegendSeed>, IPDXSerializable {
+internal sealed class LegendSeedCollection : ConcurrentIdObjectCollection<string, LegendSeed>, IPDXSerializable {
 	public void LoadSeeds(ModFilesystem ck3ModFS) {
 		Logger.Info("Loading legend seeds...");
 

@@ -5,7 +5,7 @@
 
 namespace ImperatorToCK3.CK3.Localization;
 
-public class CK3LocBlock : IIdentifiable<string> { // TODO: add ILocBlock interface that both this and commonItems' LocBlock would implement.
+internal class CK3LocBlock : IIdentifiable<string> { // TODO: add ILocBlock interface that both this and commonItems' LocBlock would implement.
 	private readonly string baseLanguage;
 	private readonly ConcurrentDictionary<string, (string, CK3LocType)> localizations = new();
 

@@ -22,7 +22,7 @@ namespace ImperatorToCK3.CK3.Provinces;
 /// </para>
 /// <para>Now 6874 history is same as 6872 history.</para>
 /// </summary>
-public sealed class ProvinceMappings : Dictionary<ulong, ulong> {
+internal sealed class ProvinceMappings : Dictionary<ulong, ulong> {
 	public ProvinceMappings(ModFilesystem ck3ModFS) {
 		var parser = new Parser();
 		RegisterKeys(parser);

@@ -3,14 +3,14 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 
-namespace ImperatorToCK3.CK3.Religions; 
+namespace ImperatorToCK3.CK3.Religions;
 
-public sealed class DoctrineCategory : IIdentifiable<string> {
+internal sealed class DoctrineCategory : IIdentifiable<string> {
 	public string Id { get; }
 	public string? GroupId { get; private set; }
 	public int NumberOfPicks { get; private set; } = 1;
 
-	private readonly OrderedSet<string> doctrineIds = new();
+	private readonly OrderedSet<string> doctrineIds = [];
 	public IReadOnlyCollection<string> DoctrineIds => doctrineIds.ToImmutableArray();
 
 	public DoctrineCategory(string id, BufferedReader categoryReader) {

@@ -38,7 +38,7 @@
 	// This is a recursive class that scrapes common/landed_titles looking for title colors, landlessness,
 	// and most importantly relation between baronies and barony provinces so we can link titles to actual clay.
 	// Since titles are nested according to hierarchy we do this recursively.
-	public sealed class LandedTitles : TitleCollection {
+	internal sealed class LandedTitles : TitleCollection {
 		public Dictionary<string, object> Variables { get; } = [];
 
 		public IEnumerable<Title> Counties => this.Where(t => t.Rank == TitleRank.county);
@@ -758,168 +758,168 @@
 			}
 		}

 		public void ImportImperatorHoldings(ProvinceCollection ck3Provinces, Imperator.Characters.CharacterCollection irCharacters, Date conversionDate) {
 			Logger.Info("Importing Imperator holdings...");
 			var counter = 0;

 			var highLevelTitlesThatHaveHolders = this
 				.Where(t => t.Rank >= TitleRank.duchy && t.GetHolderId(conversionDate) != "0")
 				.ToImmutableList();
 			var highLevelTitleCapitalBaronyIds = highLevelTitlesThatHaveHolders
 				.Select(t=>t.CapitalCounty?.CapitalBaronyId ?? t.CapitalBaronyId)
 				.ToImmutableHashSet();

 			// Dukes and above should be excluded from having their holdings converted.
 			// Otherwise, governors with holdings would own parts of other governorships.
 			var dukeAndAboveIds = highLevelTitlesThatHaveHolders
 				.Where(t => t.Rank >= TitleRank.duchy)
 				.Select(t => t.GetHolderId(conversionDate))
 				.ToImmutableHashSet();

 			// We exclude baronies that are capitals of duchies and above.
 			var eligibleBaronies = this
 				.Where(t => t.Rank == TitleRank.barony)
 				.Where(b => !highLevelTitleCapitalBaronyIds.Contains(b.Id))
 				.ToArray();

 			var countyCapitalBaronies = eligibleBaronies
 				.Where(b => b.DeJureLiege?.CapitalBaronyId == b.Id)
 				.OrderBy(b => b.Id)
 				.ToArray();

 			var nonCapitalBaronies = eligibleBaronies.Except(countyCapitalBaronies).OrderBy(b => b.Id).ToArray();


 			// In CK3, a county holder shouldn't own baronies in counties that are not their own.
 			// This dictionary tracks what counties are held by what characters.
 			Dictionary<string, HashSet<string>> countiesPerCharacter = []; // characterId -> countyIds

 			// Evaluate all capital baronies first (we want to distribute counties first, then baronies).
 			foreach (var barony in countyCapitalBaronies) {
 				var ck3Province = GetBaronyProvince(barony);
 				if (ck3Province is null) {
 					continue;
 				}

 				// Skip none holdings and temple holdings.
 				if (ck3Province.GetHoldingType(conversionDate) is "church_holding" or "none") {
 					continue;
 				}

 				var irProvince = ck3Province.PrimaryImperatorProvince; // TODO: when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces
 				var ck3Owner = GetEligibleCK3OwnerForImperatorProvince(irProvince);
 				if (ck3Owner is null) {
 					continue;
 				}

 				var realm = ck3Owner.ImperatorCharacter?.HomeCountry?.CK3Title;
 				var deFactoLiege = realm;
 				if (realm is not null) {
 					var deJureDuchy = barony.DeJureLiege?.DeJureLiege;
 					if (deJureDuchy is not null && deJureDuchy.GetHolderId(conversionDate) != "0" && deJureDuchy.GetTopRealm(conversionDate) == realm) {
 						deFactoLiege = deJureDuchy;
 					} else {
 						var deJureKingdom = deJureDuchy?.DeJureLiege;
 						if (deJureKingdom is not null && deJureKingdom.GetHolderId(conversionDate) != "0" && deJureKingdom.GetTopRealm(conversionDate) == realm) {
 							deFactoLiege = deJureKingdom;
 						}
 					}
 				}

 				// Barony is a county capital, so set the county holder to the holding owner.
 				var county = barony.DeJureLiege;
 				if (county is null) {
 					Logger.Warn($"County capital barony {barony.Id} has no de jure county!");
 					continue;
 				}
 				county.SetHolder(ck3Owner, conversionDate);
 				county.SetDeFactoLiege(deFactoLiege, conversionDate);

 				if (!countiesPerCharacter.TryGetValue(ck3Owner.Id, out var countyIds)) {
 					countyIds = [];
 					countiesPerCharacter[ck3Owner.Id] = countyIds;
 				}
 				countyIds.Add(county.Id);

 				++counter;
 			}

 			// In CK3, a baron that doesn't own counties can only hold a single barony.
 			// This dictionary IDs of such barons that already hold a barony.
 			HashSet<string> baronyHolderIds = [];

 			// After all possible county capital baronies are distributed, distribute the rest of the eligible baronies.
 			foreach (var barony in nonCapitalBaronies) {
 				var ck3Province = GetBaronyProvince(barony);
 				if (ck3Province is null) {
 					continue;
 				}

 				// Skip none holdings and temple holdings.
 				if (ck3Province.GetHoldingType(conversionDate) is "church_holding" or "none") {
 					continue;
 				}

 				var irProvince = ck3Province.PrimaryImperatorProvince; // TODO: when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces
 				var ck3Owner = GetEligibleCK3OwnerForImperatorProvince(irProvince);
 				if (ck3Owner is null) {
 					continue;
 				}
 				if (baronyHolderIds.Contains(ck3Owner.Id)) {
 					continue;
 				}

 				var county = barony.DeJureLiege;
 				if (county is null) {
 					Logger.Warn($"Barony {barony.Id} has no de jure county!");
 					continue;
 				}
 				// A non-capital barony cannot be held by a character that owns a county but not the county the barony is in.
 				if (countiesPerCharacter.TryGetValue(ck3Owner.Id, out var countyIds) && !countyIds.Contains(county.Id)) {
 					continue;
 				}

 				barony.SetHolder(ck3Owner, conversionDate);
 				// No need to set de facto liege for baronies, they are tied to counties.

 				baronyHolderIds.Add(ck3Owner.Id);

 				++counter;
 			}
 			Logger.Info($"Imported {counter} holdings from I:R.");
 			Logger.IncrementProgress();
 			return;

 			Province? GetBaronyProvince(Title barony) {
 				var ck3ProvinceId = barony.ProvinceId;
 				if (ck3ProvinceId is null) {
 					return null;
 				}
 				if (!ck3Provinces.TryGetValue(ck3ProvinceId.Value, out var ck3Province)) {
 					return null;
 				}
 				return ck3Province;
 			}

 			Character? GetEligibleCK3OwnerForImperatorProvince(Imperator.Provinces.Province? irProvince) {
 				var holdingOwnerId = irProvince?.HoldingOwnerId;
 				if (holdingOwnerId is null) {
 					return null;
 				}

 				var irOwner = irCharacters[holdingOwnerId.Value];
 				var ck3Owner = irOwner.CK3Character;
 				if (ck3Owner is null) {
 					return null;
 				}
 				if (dukeAndAboveIds.Contains(ck3Owner.Id)) {
 					return null;
 				}

 				return ck3Owner;
 			}
 		}

 		public void RemoveInvalidLandlessTitles(Date ck3BookmarkDate) {
 			Logger.Info("Removing invalid landless titles...");
 			var removedGeneratedTitles = new HashSet<string>();

@@ -3,7 +3,7 @@
 
 namespace ImperatorToCK3.CommonUtils;
 
-public sealed class ConcurrentIgnoredKeywordsSet : ConcurrentSet<string> {
+internal sealed class ConcurrentIgnoredKeywordsSet : ConcurrentSet<string> {
 	public override string ToString() {
 		return string.Join(", ", this.Order());
 	}

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.CommonUtils;
 
-public sealed class FieldValue {
+internal sealed class FieldValue {
 	public object? Value { get; set; }
 	public string Setter { get; set; } // setter that was used to set the value
 	public FieldValue(object? value, string setter) {

@@ -1,5 +1,5 @@
 namespace ImperatorToCK3.CommonUtils.Genes;
 
-public class Gene {
+internal class Gene {
 	public bool Inheritable { get; internal set; } = true;
 }
@@ -4,7 +4,7 @@
 
 namespace ImperatorToCK3.CommonUtils.Genes; 
 
-public sealed class MorphGene : Gene, IIdentifiable<string> {
+internal sealed class MorphGene : Gene, IIdentifiable<string> {
 	public string Id { get; }
 	public uint? Index { get; private set; }
 	public IdObjectCollection<string, MorphGeneTemplate> GeneTemplates { get; } = [];

@@ -3,7 +3,7 @@
 
 namespace ImperatorToCK3.CommonUtils.Genes;
 
-public sealed class MorphGeneTemplate : IIdentifiable<string> {
+internal sealed class MorphGeneTemplate : IIdentifiable<string> {
 	public string Id { get; }
 	public uint Index { get; private set; } = 0;
 	public bool Visible { get; private set; } = true;

@@ -5,7 +5,7 @@
 
 namespace ImperatorToCK3.CommonUtils.Genes;
 
-public sealed class WeightBlock {
+internal sealed class WeightBlock {
 	public uint SumOfAbsoluteWeights { get; private set; } = 0;
 	private readonly List<KeyValuePair<string, uint>> objectsList = [];
 

@@ -6,7 +6,7 @@
 
 namespace ImperatorToCK3.CommonUtils;
 internal sealed class HistoryFactory {
-	public sealed class HistoryFactoryBuilder {
+	internal sealed class HistoryFactoryBuilder {
 		private readonly List<SimpleFieldDef> simpleFieldDefs = []; // fieldName, setters, initialValue
 		private readonly List<SimpleFieldDef> literalFieldDefs = []; // fieldName, setters, initialValue
 		private readonly List<DiffFieldDef> diffFieldDefs = []; // fieldName, inserter, remover, initialValue

@@ -3,7 +3,7 @@
 
 namespace ImperatorToCK3.CommonUtils;
 
-public sealed class IgnoredKeywordsSet : HashSet<string> {
+internal sealed class IgnoredKeywordsSet : HashSet<string> {
 	public override string ToString() {
 		return string.Join(", ", this.Order());
 	}

@@ -3,7 +3,7 @@
 
 namespace ImperatorToCK3.CommonUtils.Map;
 
-public sealed class ProvinceDefinition(ulong id) : IIdentifiable<ulong> {
+internal sealed class ProvinceDefinition(ulong id) : IIdentifiable<ulong> {
 	public ulong Id { get; } = id;
 	private readonly HashSet<SpecialProvinceCategory> specialCategories = [];
 

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.CommonUtils.Map;
 
-public sealed class ProvincePosition {
+internal sealed class ProvincePosition {
 	public ulong Id { get; private set; }
 	public double X { get; private set; }
 	public double Y { get; private set; }

@@ -2,8 +2,8 @@
 
 namespace ImperatorToCK3.CommonUtils;
 
-public sealed class SimpleFieldDef {
+internal sealed class SimpleFieldDef {
 	public string FieldName { get; init; } = "";
-	public OrderedSet<string> Setters { get; init; } = new();
+	public OrderedSet<string> Setters { get; init; } = [];
 	public object? InitialValue { get; init; }
 }
@@ -10,8 +10,8 @@
 
 namespace ImperatorToCK3;
 
-public enum LegionConversion { No, SpecialTroops, MenAtArms }
-public sealed class Configuration {
+internal enum LegionConversion { No, SpecialTroops, MenAtArms }
+internal sealed class Configuration {
 	public string SaveGamePath { get; set; } = "";
 	public string ImperatorPath { get; set; } = "";
 	public string ImperatorDocPath { get; set; } = "";

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.Exceptions;
 
-public class ConverterException : Exception {
+internal class ConverterException : Exception {
 	public ConverterException(string message) : base(message) { }
 
 	public ConverterException(string? message, Exception? innerException) : base(message, innerException) { }

@@ -3,7 +3,7 @@
 using ImperatorToCK3.CommonUtils;
 
 namespace ImperatorToCK3.Imperator.Armies;
-public sealed class Subunit : IIdentifiable<ulong> {
+internal sealed class Subunit : IIdentifiable<ulong> {
 	public ulong Id { get; }
 	public string Category { get; private set; } = "levy";
 	public string Type { get; private set; } = "light_infantry";

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.Imperator.Characters;
 
-public sealed class CharacterAttributes {
+internal sealed class CharacterAttributes {
 	public int Martial { get; set; } = 0;
 	public int Finesse { get; set; } = 0;
 	public int Charisma { get; set; } = 0;

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.Imperator.Characters;
 
-public sealed class CharacterName {
+internal sealed class CharacterName {
 	public string Name { get; private set; } = string.Empty; // key for localization or literal name
 	public string? CustomName { get; private set; } // localized
 

@@ -1,6 +1,6 @@
 namespace ImperatorToCK3.Imperator.Characters; 
 
-public sealed class PaletteCoordinates {
+internal sealed class PaletteCoordinates {
 	// palettes are 512x512
 	public int X { get; set; } = 256;
 	public int Y { get; set; } = 256;

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.Imperator.Characters;
 
-public sealed class Unborn {
+internal sealed class Unborn {
 	public ulong MotherId { get; }
 	public ulong FatherId { get; }
 	public Date BirthDate { get; }

@@ -3,7 +3,7 @@
 
 namespace ImperatorToCK3.Imperator.Countries;
 
-public sealed class CountryCurrencies : Parser {
+internal sealed class CountryCurrencies : Parser {
 	public double Manpower { get; private set; } = 0;
 	public double Gold { get; private set; } = 0;
 	public double Stability { get; private set; } = 50;

@@ -6,7 +6,7 @@
 namespace ImperatorToCK3.Imperator.Countries;
 
 internal sealed class RulerTerm {
-	public sealed class PreImperatorRulerInfo {
+	internal sealed class PreImperatorRulerInfo {
 		public string? Name { get; set; }
 		public Date? BirthDate { get; set; }
 		public Date? DeathDate { get; set; }

@@ -4,7 +4,7 @@
 
 namespace ImperatorToCK3.Imperator.Cultures;
 
-public sealed class Culture : IIdentifiable<string> {
+internal sealed class Culture : IIdentifiable<string> {
 	public string Id { get; }
 	private readonly Dictionary<string, string> familyNamesDict = new(); // <key, male form>
 

@@ -4,7 +4,7 @@
 
 namespace ImperatorToCK3.Imperator.Cultures;
 
-public sealed class CultureGroup : IdObjectCollection<string, Culture>, IIdentifiable<string> {
+internal sealed class CultureGroup : IdObjectCollection<string, Culture>, IIdentifiable<string> {
 	public string Id { get; }
 	private readonly Dictionary<string, string> familyNamesDict = new(); // <key, male form>
 

@@ -4,7 +4,7 @@
 
 namespace ImperatorToCK3.Imperator.Cultures;
 
-public sealed class CulturesDB : IdObjectCollection<string, CultureGroup> {
+internal sealed class CulturesDB : IdObjectCollection<string, CultureGroup> {
 	public void Load(ModFilesystem irModFS) {
 		Logger.Info("Loading cultures database...");
 

@@ -2,7 +2,7 @@
 using commonItems.Mods;
 namespace ImperatorToCK3.Imperator;
 
-public sealed class ImperatorDefines : Defines {
+internal sealed class ImperatorDefines : Defines {
 	public int CohortSize { get; private set; } = 500;
 
 	public new void LoadDefines(ModFilesystem modFS) {

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.Imperator.Diplomacy;
 
-public sealed class Dependency(ulong overlordId, ulong subjectId, Date startDate, string subjectType) {
+internal sealed class Dependency(ulong overlordId, ulong subjectId, Date startDate, string subjectType) {
 	public ulong OverlordId { get; } = overlordId;
 	public ulong SubjectId { get; } = subjectId;
 	public Date StartDate { get; } = startDate;

@@ -6,7 +6,7 @@
 
 namespace ImperatorToCK3.Imperator.Inventions;
 
-public sealed class InventionsDB {
+internal sealed class InventionsDB {
 	private readonly OrderedSet<string> inventionIds = [];
 
 	public IReadOnlyCollection<string> InventionIds => inventionIds;

@@ -3,7 +3,7 @@
 
 namespace ImperatorToCK3.Imperator.Pops;
 
-public sealed class Pop : IIdentifiable<ulong> {
+internal sealed class Pop : IIdentifiable<ulong> {
 	public ulong Id { get; } = 0;
 	public string Type { get; set; } = "";
 	public string Culture { get; set; } = "";

@@ -6,7 +6,7 @@
 
 namespace ImperatorToCK3.Imperator.Pops;
 
-public sealed class PopCollection : ConcurrentIdObjectCollection<ulong, Pop> {
+internal sealed class PopCollection : ConcurrentIdObjectCollection<ulong, Pop> {
 	public void LoadPopsFromBloc(BufferedReader blocReader) {
 		var blocParser = new Parser();
 		blocParser.RegisterKeyword("population", LoadPops);

@@ -2,7 +2,7 @@
 
 namespace ImperatorToCK3.Imperator.Provinces;
 
-public sealed class ProvinceName {
+internal sealed class ProvinceName {
 	public string Name { get; private set; } = "";
 
 	public ProvinceName(BufferedReader reader) {

@@ -5,7 +5,7 @@
 
 namespace ImperatorToCK3.Imperator.Religions;
 
-public sealed class Deity : IIdentifiable<string> {
+internal sealed class Deity : IIdentifiable<string> {
 	public string Id { get; }
 	public OrderedDictionary<string, double> PassiveModifiers { get; } = [];
 

@@ -3,7 +3,7 @@
 
 namespace ImperatorToCK3.Imperator.Religions;
 
-public sealed class Religion : IIdentifiable<string> {
+internal sealed class Religion : IIdentifiable<string> {
 	public string Id { get; }
 	public OrderedDictionary<string, double> Modifiers { get; }