Refactoring QEC Tablegen into QECOps and QECDialect (#2253)

Author: lazypanda10117

doc/releases/changelog-dev.md

@@ -317,6 +317,11 @@
   [(#2245)](https://github.com/PennyLaneAI/catalyst/pull/2245)
   [(#2254)](https://github.com/PennyLaneAI/catalyst/pull/2254)
 
+
+  * Refactor QEC tablegen files to separate QEC operations into a new `QECOp.td` file
+  [(#2253](https://github.com/PennyLaneAI/catalyst/pull/2253)	
+
+
 <h3>Documentation 📝</h3>
 
 * A typo in the code example for :func:`~.passes.ppr_to_ppm` has been corrected.

mlir/include/QEC/IR/CMakeLists.txt

@@ -1,9 +1,10 @@
-add_mlir_dialect(QECDialect qec)
+add_mlir_dialect(QECOps qec)
 add_mlir_interface(QECOpInterfaces)
-add_mlir_doc(QECDialect QECDialect QEC/ -gen-dialect-doc -gen-op-doc)
+add_mlir_doc(QECDialect QECDialect QEC/ -gen-dialect-doc -dialect qec)
+add_mlir_doc(QECOps QECOps QEC/ -gen-op-doc)
 add_mlir_doc(QECOpInterfaces QECOpInterfaces QEC/ -gen-op-interface-docs)
 
-set(LLVM_TARGET_DEFINITIONS QECDialect.td)
+set(LLVM_TARGET_DEFINITIONS QECOps.td)
 mlir_tablegen(QECEnums.h.inc -gen-enum-decls)
 mlir_tablegen(QECEnums.cpp.inc -gen-enum-defs)
 mlir_tablegen(QECAttributes.h.inc -gen-attrdef-decls)

mlir/include/QEC/IR/QECDialect.h

@@ -14,31 +14,23 @@
 
 #pragma once
 
-#include "mlir/Bytecode/BytecodeOpInterface.h"
-#include "mlir/IR/BuiltinTypes.h"
 #include "mlir/IR/Dialect.h"
-#include "mlir/IR/OpDefinition.h"
-#include "mlir/IR/PatternMatch.h"
-#include "mlir/Interfaces/ControlFlowInterfaces.h"
-#include "mlir/Interfaces/SideEffectInterfaces.h"
-
-#include "QEC/IR/QECOpInterfaces.h"
 
 //===----------------------------------------------------------------------===//
 // QEC dialect declarations.
 //===----------------------------------------------------------------------===//
 
-#include "QEC/IR/QECDialectDialect.h.inc"
+#include "QEC/IR/QECOpsDialect.h.inc"
 
 //===----------------------------------------------------------------------===//
 // QEC type declarations.
 //===----------------------------------------------------------------------===//
 
 #define GET_TYPEDEF_CLASSES
-#include "QEC/IR/QECDialectTypes.h.inc"
+#include "QEC/IR/QECOpsTypes.h.inc"
 
 //===----------------------------------------------------------------------===//
-// QEC enum definitions.
+// QEC enum declarations.
 //===----------------------------------------------------------------------===//
 
 #include "QEC/IR/QECEnums.h.inc"
@@ -49,10 +41,3 @@
 
 #define GET_ATTRDEF_CLASSES
 #include "QEC/IR/QECAttributes.h.inc"
-
-//===----------------------------------------------------------------------===//
-// QEC ops declarations.
-//===----------------------------------------------------------------------===//
-
-#define GET_OP_CLASSES
-#include "QEC/IR/QECDialect.h.inc"