Use transform pass name #2206
Open
Use transform pass name #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Nov 20, 2025
albi3ro
commented
Nov 20, 2025
| """ | ||
|
|
||
| if fn.mlir_module is not None: |
Contributor
Author
There was a problem hiding this comment.
Just switching to using a guard clause here. No actual code changes, but made it easier to scan the source code and see what was happening.
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Member
|
Did you accidentally commit the intermediates? 😅 |
Contributor
Author
looks like yes ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In #2149 I'm integrating transforms with passes names with the infrastructure so that we can replace the Catalyst
Passinstracture with a unified transform handling ecosystem.In order to test this integration, I'm just switching the passes over to use the transform instructure.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: