Refactoring QEC Tablegen into QECOps and QECDialect #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazypanda10117
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2253 +/- ##
=========================================
Coverage 97.56% 97.56%
=========================================
Files 22 93 +71
Lines 2340 11149 +8809
Branches 0 1063 +1063
=========================================
+ Hits 2283 10878 +8595
- Misses 57 207 +150
- Partials 0 64 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sengthai
approved these changes
Dec 1, 2025
Contributor
sengthai
left a comment
sengthai
left a comment
There was a problem hiding this comment.
Great! Thanks @lazypanda10117. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The QECDialect td file currently contains definitions of the QEC operations. We want to refactor the file into two td files, QECDialect and QECOp, for better maintainability.
Description of the Change: Refactor the
QECDialect.tdfile intoQECDialect.tdandQECOp.td, and make corresponding changes across the QEC dialect to support this refactoring.